Fix a regression with searching for closed review requests.

Review Request #1024 — Created Dec. 25, 2017 and updated

guest7377
Review Board
08fdb38...
demo
rr
When the search API was rewritten, it was updated to use `public()` in
order to be more secure. This ended up using the default of only
returning opened review requests, excluding any closed ones, regressing
the ability to match those in the quick search results.

This changes that query to not limit results to open review requests,
and adds unit tests to ensure this doesn't regress.

Testing Done:
Unit tests pass. They failed prior to the fix.

Reviewed at https://reviews.reviewboard.org/r/9424/

ttt

  • 3
  • 0
  • 2
  • 0
  • 5
Description From Last Updated
This might be good to move to another place. guest6724 guest6724
This is a test comment. Do this a different way. guest8017 guest8017
line 495 guest3207 guest3207
guest8017
  1. After reviewing the code, it looks good except for a few things. See comments.

  2. reviewboard/webapi/tests/test_search.py (Diff revision 1)
     
     

    This is a test comment. Do this a different way.

  3. 
      
guest6724
  1. test

  2. Testing functionality

  3. 
      
guest6724
  1. Ship It!
  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    This comment is quite cool

  3. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    This might be good to move to another place.

  4. 
      
guest9002
  1. Ship It!
  2. 
      
guest3207
  1. overall good stuff

  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    test comment on a line

  3. reviewboard/webapi/tests/test_search.py (Diff revision 1)
     
     

    line 495

  4. 
      
guest558
  1. 
      
  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     
    123
  3. 
      
Loading...