Add "Publish and Archive" to the review dialog.

Review Request #1041 — Created Jan. 25, 2018 and submitted

guest1224
Review Board
29aa306...
demo
guest1224
This change adds a shortcut allowing people who are publishing a review
to publish the review and archive the review request all in one shot.

Testing done:
- Manually tested adding a comment and clicking "Publish and Archive"
  from the banner. Once published, the review request is marked as
  archived. Manually tested adding a comment, clicking "Edit Review" from
  the banner, and clicking "Publish and Archive" from the review dialog
  view. Once published, the review request is marked as archived.
- Added 3 unit tests, which all pass (along with all other tests). One
  scenario creates a new visit and archives the review request. The other
  two scenarios update existing visits from visible to visible, and
  visible to archived.
- Added a javascript test to ensure that onPublishClicked is called with
  the correct values.

Reviewed at https://reviews.reviewboard.org/r/9220/


Description From Last Updated

Comment

guest1224guest1224

good

guest1224guest1224

perfect

guest1224guest1224

yes. that sounds better

guest1224guest1224

ok

guest1224guest1224

hummm

guest7616guest7616

single line comment

guest1224guest1224

several line comment

guest1224guest1224

japp thats ok

guest1224guest1224

ok

guest1224guest1224

good enough

guest1224guest1224

ok

guest1224guest1224

wrong code

guest1224guest1224

ok

guest1224guest1224
guest1224
  1. TEst

  2. Comment

  3. 
      
guest1224
  1. 
      
  2. reviewboard/accounts/managers.py (Diff revision 1)
     
     
  3. reviewboard/accounts/managers.py (Diff revision 1)
     
     
     
     

    perfect

  4. reviewboard/accounts/managers.py (Diff revision 1)
     
     

    yes. that sounds better

  5. reviewboard/accounts/managers.py (Diff revision 1)
     
     
     
     
     
     
  6. reviewboard/accounts/managers.py (Diff revision 1)
     
     

    single line comment

  7. reviewboard/accounts/managers.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    several line comment

  8. reviewboard/accounts/managers.py (Diff revision 1)
     
     

    japp thats ok

  9. 
      
guest1224
  1. 
      
  2. reviewboard/accounts/tests.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  3. reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
  4. wrong code

  5. reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
  6. 
      
guest1224
Review request changed

Status: Closed (submitted)

guest7616
  1. 
      
  2. reviewboard/accounts/managers.py (Diff revision 1)
     
     
  3. 
      
Loading...