Clean up the API extra data access hooks

Review Request #115 — Created Oct. 26, 2016 and updated

guest3004
Review Board
JIRA-1234
f3af594...
demo
The `APIExtraDataAccessHook` has been rewritten to utilize registries
for registration and unregistration of callbacks. Tests have been
updated for these changes.

The documetnation has also been updated and reformatted for clarity.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/8084/


Description From Last Updated

yes

guest1601guest1601

This is test comment

guest7973guest7973

I have written the test header, but don't know what to do next

guest7384guest7384

this is a test

guest6613guest6613

testttttt

guest2302guest2302

??? ????

guest2302guest2302

180225002

guest2302guest2302

20180205003

guest2302guest2302

not intuitive to understand

guest5739guest5739

somehthing

guest1201guest1201

jnkjnkjnkj

guest9410guest9410

Blah

guest6731guest6731

Testing comments

guest6731guest6731

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

guest8943guest8943

Comment to the line 29

guest7384guest7384

This comment created for the red block

guest7384guest7384

aaa

guest8943guest8943

ah e tal ta bem

guest3867guest3867

add validation

guest6427guest6427

modify the method.

guest6427guest6427

Shocking!

guest7457guest7457

very good

guest6445guest6445

why so serious ?

guest6636guest6636

Needs more cats!

guest7457guest7457

Need more egg resource.register_extra_data_access_callback(self.get_extra_data_state)

guest7973guest7973

agree

guest5739guest5739

Why not let the code formatting tool do this?

guest4635guest4635

This should be 4 instead of 3 because...bla bla

guest1561guest1561

Delete

guest7959guest7959

Implement ASAP!

guest4409guest4409

fff

guest2310guest2310

comment

guest6527guest6527
guest3004
Review request changed

Groups:

+demo

People:

-moomin
guest9613
  1. hello

  2. 
      
guest1601
  1. aaa

  2. 
      
guest9094
  1. Ship It!
  2. 
      
guest7457
  1. Try again

  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Needs more cats!

  3. 
      
guest6527
guest3867
  1. 
      
  2. docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    ah e tal ta bem

  3. 
      
guest7959
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     
     
     
  3. 
      
guest112
  1. 
      
  2. 
      
guest4635
  1. 
      
  2. reviewboard/extensions/tests.py (Diff revision 1)
     
     
     

    Why not let the code formatting tool do this?

  3. 
      
guest9410
  1. okok

  2. 
      
guest9410
guest1561
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     

    This should be 4 instead of 3 because...bla bla

  3. 
      
guest2450
  1. test

  2. 
      
guest2450
  1. Ship It!
  2. 
      
guest6731
guest4409
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Implement ASAP!

  3. 
      
guest7973
  1. review it

  2. This is test comment

  3. This is test footer

guest7973
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     

    Need more egg

    resource.register_extra_data_access_callback(self.get_extra_data_state)

  3. 
      
guest6427
guest6427
guest6427
  1. Ship It!
  2. 
      
guest1201
  1. body top helllooo

    something

  2. test
    
    world
    
    of world
  3. somehthing

  4. tail workld
guest1201
  1. tail odd
  2. docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    too long
  3. we want a tail
guest1201
  1. 
      
  2. reviewboard/extensions/tests.py (Diff revision 1)
     
     
     
     
     
     
    THe quick brown
  3. 
      
guest1201
  1. hello world body
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     
     
     
     
     
    On branch master
    Your branch is up-to-date with 'origin/master'.
    Changes not staged for commit:
      (use "git add <file>..." to update what will be committed)
      (use "git checkout -- <file>..." to discard changes in working directory)
    
            modified:   rboard.py
  3. 
      
guest7384
  1. Test header for the review

  2. I have written the test header, but don't know what to do next

  3. Test footer

guest7384
guest7384
  1. I try to review

  2. This comment created for the red block

  3. 
      
guest6636
guest5739
  1. 
      
  2. docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    not intuitive to understand

  3. 
      
guest5739
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
  3. 
      
guest6445
guest6613
  1. 
      
  2. this is a test

  3. 
      
guest8874
guest8874
guest2302
  1. Ship It!
  2. 
      
guest2302
guest2302
  1. 
      
  2. sdfas

  3. 
      
guest2302
  1. 
      
  2. 180225fdsfa

  3. 
      
guest2302
  1. 
      
  2. 180225002

  3. 
      
guest2302
  1. 
      
  2. 20180205003

  3. 
      
guest2302
  1. ?

  2. 
      
guest8943
  1. 
      
  2. docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  3. 
      
guest8943
  1. 
      
  2. aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

  3. 
      
guest2310
  1. 
      
  2. 
      
guest2310
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     
  3. 
      
Loading...