Clean up the API extra data access hooks

Review Request #115 - Created Oct. 26, 2016 and updated

guest3004
Review Board
JIRA-1234
f3af594...
demo
The `APIExtraDataAccessHook` has been rewritten to utilize registries
for registration and unregistration of callbacks. Tests have been
updated for these changes.

The documetnation has also been updated and reformatted for clarity.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/8084/

  
  • 11
  • 1
  • 2
  • 14
Description From Last Updated
jnkjnkjnkj guest9410 guest9410
Blah guest6731 guest6731
Testing comments guest6731 guest6731
ah e tal ta bem guest3867 guest3867
Shocking! guest7457 guest7457
Needs more cats! guest7457 guest7457
Need more egg resource.register_extra_data_access_callback(self.get_extra_data_state) guest7973 guest7973
Why not let the code formatting tool do this? guest4635 guest4635
This should be 4 instead of 3 because...bla bla guest1561 guest1561
yes guest1601 guest1601
This is test comment guest7973 guest7973
guest3004
Review request changed

Groups:

+demo

People:

-moomin
guest9613
  1. hello

guest1601
  1. aaa

guest9094
  1. Ship It!
guest7457
  1. Try again

  2. Shocking!

  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Needs more cats!

guest6527
  1. ddd

  2. reviewboard/webapi/base.py (Diff revision 1)
     
     

    comment

    1. Hello, TEST 12092016

    2. T

guest3867
  1. 
      
  2. docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    ah e tal ta bem

guest7959
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     
     
     
guest112
  1. 
      
guest4635
  1. 
      
  2. reviewboard/extensions/tests.py (Diff revision 1)
     
     
     

    Why not let the code formatting tool do this?

guest9410
  1. okok

guest9410
guest1561
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     

    This should be 4 instead of 3 because...bla bla

guest2450
  1. test

guest2450
  1. Ship It!
guest6731
guest4409
  1. 
      
  2. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Implement ASAP!

guest7973
  1. review it

  2. This is test comment

  3. This is test footer

guest7973
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     

    Need more egg

    resource.register_extra_data_access_callback(self.get_extra_data_state)

Loading...