Fix regressions from recent authentication backend cleanup.

Review Request #1317 — Created July 16, 2018 and updated

guest8397
Review Board
4a35952...
demo
There were two issues found with the recent changes meant to split up
and document the authentication backends.

1) `BaseAuthBackend.get_user()` was accidentally removed with commit
    a12a370fd.

    This function is required by Django to fetch a user for a given
    database ID.

2) The `ldap` backend's module was being imported by the Active
   Directory backend instead of the top-level `ldap` module. This
   required importing `absolute_import` to ensure the local module
   wasn't used.

Testing Done:
* Created Docker container form easybe/alpine-reviewboard:wip
* Successfully logged in with Active Directory credentials

Reviewed at https://reviews.reviewboard.org/r/10045/


  • 3
  • 0
  • 7
  • 1
  • 11
Description From Last Updated
re not required spelling mistake? guest527 guest527
verify guest2656 guest2656
more stuff guest1225 guest1225
guest1225
  1. 
      
  2. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     

    Questionable at best

  3. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     

    more stuff

  4. 
      
guest3929
  1. 
      
  2. reviewboard/accounts/backends/ad.py (Diff revision 1)
     
     

    issue 1

  3. 
      
guest1772
  1. Ship It!
  2. 
      
guest2656
guest527
  1. Ship It!
  2. 
      
guest527
  1. Ship It!
  2. 
      
guest527
  1. Header comment is this.

    • This is general comment with md
    • This is second line
  2. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     
     
    • re not required
    • spelling mistake?
  3. Footer for what?

guest5693
  1. ASDSADSADS

  2. 
      
guest5693
  1. çl,,,ç,

  2. 
      
guest8293
  1. Verify

  2. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     
    Why2?
  3. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     
    Why?
  4. 
      
guest8502
  1. Ship It!
  2. 
      
guest8502
  1. Header of the review

  2. General comments

  3. Footer

guest2130
  1. 
      
  2. reviewboard/accounts/backends/base.py (Diff revision 1)
     
     

    Unnecessary blank line

  3. 
      
guest3500
Loading...