Add an API for commenting on FileDiffs ranges

Review Request #1467 — Created Nov. 20, 2018 and submitted

guest375
Review Board
d14df94...
guest3011
The `ReviewDiffCommentResource` is now capable of creating comments on
FileDiffs with a base FileDiff ID. This allows us to comment on
FileDiffs in commit ranges and keep the context of the base FileDiff.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/10190/


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
guest3011
  1. 
      
  2. This needs an else check too.
  3. Be sure to test this.
  4. 
      
guest375
  1. 
      
  2. Please verify this is the correct state.

  3. 
      
guest375
  1. 
      
  2. docs/manual/glossary.rst (Diff revision 1)
     
     
     
     
     
     
     
     

    The multi-source-line comment is a cool feature

  3. 
      
guest375
  1. 
      
  2. Verification test

    1. Great, so I cannot mark this fixed. yet you marked my comment fixed.
  3. 
      
guest375
  1. 
      
  2. Woo hoo... down the rabit hole we go!

    1. And I can only reply to this one.

  3. 
      
guest375
Review request changed

Status: Closed (submitted)

Loading...