Add support for modern Bitbucket webhooks.

Review Request #1518 — Created Dec. 28, 2018 and updated

guest9014
Review Board
2e9945e...
demo
Our support for Bitbucket webhooks was dependent on their legacy
implementation, which they've recently removed. They have a newer model
with different configuration requirements, different payload format,
and restrictions on the number of commits that are represented.

This change updates to work with the new format. We now only accept the
modern payload format, using the contained commit information if not
marked "truncated", falling back to calling into the Bitbucket API if
needed.

The instructions have been updated for the new configuration process. A
notable change is that we can no longer pre-fill in any information in
the configuration form, but instead need users to provide it themselves.

Testing Done:
Unit tests pass.

Manually tested with both truncated and non-truncated push event payloads.
Verified that the payloads were parsed correctly and that each commit
referencing a review request URL was properly handled.

Reviewed at https://reviews.reviewboard.org/r/10344/

No test was done

Description From Last Updated

test

guest8567guest8567

Looks good

guest3163guest3163

was wrong with this?

guest1615guest1615

Ez nem jo!

guest6419guest6419

Just a silly comment

guest7304guest7304

just a test

guest644guest644

I dont like new stuff. Why do we need this?

guest7304guest7304

Multiline!

guest7304guest7304

Wouldn't it be better to rewrite the whole thing as an email client?

guest1494guest1494

AAAAAAAAAAAAAAAAAAAA

guest3505guest3505

not bad

guest8567guest8567
guest644
  1. 
      
  2. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     

    just a test

  3. 
      
guest644
  1. Ship It!
  2. 
      
guest8567
guest8567
  1. test

  2. 
      
guest8567
  1. aaaa

  2. 
      
guest8567
  1. Ship It!
  2. 
      
guest8567
guest7304
  1. 
      
  2. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     

    Just a silly comment

  3. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     

    I dont like new stuff. Why do we need this?

  4. 
      
guest7304
  1. 
      
  2. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Multiline!

  3. 
      
guest7304
  1. Ship It!
  2. 
      
guest1615
  1. 
      
  2. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     

    was wrong with this?

  3. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     

    ok test

  4. 
      
guest1615
  1. ???

  2. 
      
guest1615
  1. Ship It!
  2. 
      
guest3292
  1. k

  2. 
      
guest6419
  1. 
      
  2. reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
     
     
     
     
     
     

    Ez nem jo!

  3. 
      
guest1494
  1. 
      
  2. Wouldn't it be better to rewrite the whole thing as an email client?

  3. 
      
guest3505
guest3163
  1. 
      
  2. Looks good

  3. 
      
guest3163
  1. Ship It!
  2. 
      
Loading...