Added Features X, Y, Z

Review Request #226 - Created Dec. 19, 2016 and updated

guest7621
Review Board
3cfd1fe...
aaa

Merge branch 'release-3.0.x'

Added features X, Y, Z

Unit tests

  • 4
  • 0
  • 2
  • 1
  • 7
Description From Last Updated
What if status is not one of the explicitly handled ones? Should you raise an exception? guest6017 guest6017
WTF is with the "!(*%!(&^" characters? guest9158 guest9158
strange guest4920 guest4920
why use this? guest4920 guest4920
guest7621
guest7621
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    This is wrong,
    What you should do is instead

    DO STUFF
    
  3. 
      
guest7621
  1. Ship It!
  2. 
      
guest7621
  1. Ship It!
  2. 
      
guest7621
Review request changed

Change Summary:

Update

Summary:

-Merge branch 'release-3.0.x'
+Added Features X, Y, Z
guest2548
  1. Ship It!
  2. 
      
guest2548
  1. test

  2. 
      
guest2548
  1. 
      
  2. This is wrong

  3. 
      
guest2548
  1. Ship It!
  2. 
      
guest2548
  1. Ship It!
  2. 
      
guest6112
  1. tfhfhtf

  2. 
      
guest6053
  1. Ship It!
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    guest6053
  3. 
      
guest6053
  1. Ship It!
  2. 
      
guest9885
  1. Ship It!
  2. 
      
guest5712
  1. that's nonsense

  2. 
      
guest6017
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     

    What if status is not one of the explicitly handled ones? Should you raise an exception?

  3. 
      
guest6017
  1. Ship It!
  2. 
      
guest5407
  1. Ship It!
  2. 
      
guest5407
  1. 123123

  2. 
      
guest4920
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     

    strange

  3. reviewboard/static/rb/js/common.es6.js (Diff revision 1)
     
     

    why use this?

  4. 
      
guest3992
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     

    MARKDOWN 2020

    • This
    • is
    • awesome

    • I also

    • Like
    • Numbers

    Can we do nice links?

      1. Why
      2. Didn't
      3. The
      4. Numbers
      5. Work
      6. Above????
  3. 
      
guest9158
  1. Ship It!
  2. 
      
guest9158
  1. 
      
  2. WTF is with the "!(*%!(&^" characters?
  3. 
      
guest940
  1. Ship It!
  2. 
      
Loading...