Make review-requests API properly handle ambiguous times.

Review Request #318 — Created Jan. 16, 2017 and updated

guest9728
Review Board
b566240...
aaa
Because we live in a silly world where some people arbitrarily move their
clocks back and forth by an hour, timestamps, even those containing timezone
information, may not be unique. In particular, this could cause problems when
fetching the `review-requests` resource using the time-limiting fields with a
timestamp that exists during the hour after the transition from
daylight-savings time to standard time.

This change fixes things up to catch the error and return a reasonable error
via the API, rather than a 500 and a traceback. This also fixes it up so
invalid timestamp strings return an error rather than getting silently ignored.

Testing done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/8607/

NO

  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
asdf wtf guest9728 guest9728
This is a test comment. Well done! guest8084 guest8084
guest9728
  1. Ship It!
  2. 
      
guest8084
  1. Ship It!
  2. This is a test comment. Well done!

  3. 
      
Loading...