Fix the sample API URL for the WebHooks unit tests.

Review Request #535 — Created March 31, 2017 and updated

guest6871
Review Board
1448466...
demo
The WebHooks unit tests were prefixing each API URL with "api/", which
other unit tests don't do. This change simply removes the "api/" prefix.

Testing Done:
Ran unit tests. Saw that they didn't include the prefix anymore.

Reviewed at https://reviews.reviewboard.org/r/8852/


Description From Last Updated

234r

guest7552guest7552

This commit sucks in a way no other commits suck

guest9193guest9193

test

guest5744guest5744

Test comment

guest2904guest2904

How can i comment on specific files ??

guest2904guest2904

Hey

guest7732guest7732

test

guest4917guest4917

Test

guest6433guest6433

I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that ...

guest44guest44

ggergegergee

guest1515guest1515

fsddsffds fdsfdsfsdfds

guest7751guest7751

toto

guest6778guest6778

test

guest6887guest6887

fjfhj

guest9517guest9517

trying to create an issue

guest1661guest1661

YOu should not strip the api from the uri

guest2904guest2904

asdfasdfa sdfa sdf asd fasdf asdf asd fasd fas dfa sdfasdf

guest7116guest7116

I like the api.. please mr. don't take it away from me!! :'(

guest9193guest9193

If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be ...

guest9517guest9517

wtf?!

guest6778guest6778

Some code

guest6871guest6871

resolved one more time. xxx

guest7116guest7116

my comment

guest9348guest9348

This is a comment

guest1256guest1256

Why has this line not changed?

guest8835guest8835

function test() { console.log('Test failed'); }

guest9348guest9348

this is bad

guest4917guest4917

this should be tested

guest5575guest5575

How can we get a unified diff instead of side-by-side view?

guest44guest44

Dont strip the api part of the uri it will broke other dependencies * Ok * * Testing 1 2 ...

guest2904guest2904

Cooment problem chang what eever

guest6449guest6449

dd

guest4434guest4434

qwe

guest7552guest7552

here as well

guest5575guest5575

test

guest2967guest2967

test2

guest2967guest2967
guest6871
  1. Please review it

  2. 
      
guest6871
  1. Another test
  2. 
      
guest6871
guest6871
  1. All fine

  2. 
      
guest7116
  1. 
      
  2. asdfasdfa sdfa sdf asd fasdf asdf
    asd
    fasd
    fas
    dfa
    sdfasdf

  3. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     

    resolved one more time. xxx

    1. do you like it?
      ===============

  4. 
      
guest831
  1. 
      
  2. csdcxc

  3. 
      
guest44
  1. 
      
  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     

    I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that multiple lines can be selected. I wish GitHub pull request code reviews had these two features.

  3. How can we get a unified diff instead of side-by-side view?

  4. 
      
guest5047
  1. Ship It!

  2. 
      
guest8184
  1. fuck it

  2. 
      
guest7467
  1. that sounds good.

  2. 
      
guest7923
  1. Ran unit tests. Saw that they didn't include the prefix anymore.?

  2. 
      
guest7552
  1. Ship It!

  2. 
      
guest7552
guest1661
  1. 
      
  2. trying to create an issue
  3. 
      
guest9193
  1. 
      
  2. I like the api.. please mr. don't take it away from me!! :'(

  3. 
      
guest9193
  1. 
      
    1. that kind of... your opinion

  2. This commit sucks in a way no other commits suck

  3. 
      
guest9517
  1. Fix that issue and then we should be good!

  2. If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be reachable ;)
  3. 
      
guest5744
guest5744
  1. 
      
  2. hkhhkjh

  3. 
      
guest9517
  1. 
      
  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     
  3. 
      
guest2904
  1. Review testing

  2. Test comment

  3. How can i comment on specific files ??

  4. YOu should not strip the api from the uri

  5. Dont strip the api part of the uri it will broke other dependencies

    * Ok *

    * Testing

    1 2 testing

    Reread comment above
    - a
    - b
    - c

  6. 
      
guest9348
  1. 
      
  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     

    my comment

  3. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     

    function test() {
        console.log('Test failed');
    }
    
  4. 
      
guest6520
  1. Ship It!
  2. 
      
guest7732
guest87
  1. Ship It!
  2. 
      
guest6457
  1. Ship It!
  2. 
      
guest3217
  1. Ship It!
  2. 
      
guest3371
  1. 🏆

  2. 
      
guest5390
  1. Ship It!
  2. 
      
guest4917
guest4917
guest9182
  1. FIx

  2. 
      
guest9182
  1. fix

  2. 
      
guest9182
  1. 2134234

  2. 
      
guest9182
  1. test

  2. 
      
guest9182
  1. 234234

  2. 
      
guest9182
  1. 123

  2. 
      
guest1256
  1. Code Review done

  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     

    This is a comment

  3. 
      
guest1256
  1. Ship It!
  2. 
      
guest2967
  1. This mostly looks good except for the below

  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     
     
     
     
  3. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     
     
  4. 
      
guest6433
guest1515
  1. Ship It!

  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     

    ggergegergee

  3. 
      
guest2824
  1. Ship It!
  2. 
      
guest6778
guest1736
  1. 
      
  2. 
      
guest8835
  1. 
      
  2. reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
     
     
     
     
     

    Why has this line not changed?

  3. 
      
guest5575
  1. 
      
  2. this should be tested

  3. here as well

  4. 
      
guest5575
  1. 
      
  2. foo

  3. 
      
guest5575
  1. Ship It!
  2. 
      
guest6449
  1. 
      
  2. Cooment problem
    chang
    what eever

  3. 
      
guest9921
  1. 
      
  2. 
      
guest6887
guest7751
  1. 
      
  2. fsddsffds
    fdsfdsfsdfds

  3. 
      
guest4434
guest333
  1. vcvcx

  2. 
      
guest8897
  1. 
      
  2. 
      
Loading...