Move HTTP basic auth into URLRequest

Review Request #666 - Created May 24, 2017 and updated

guest7536
Review Board
19ddbe6...
guest7536
The logic for adding HTTP basic auth headers to a request has been moved
into the `URLRequest` class since it is generally useful. In addition,
the `HostingServiceClient._build_request` method has been removed since
it was used in one place; its definition has been moved inline.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/8911/

  
  • 3
  • 0
  • 0
  • 3
Description From Last Updated
This looks bad to me. guest4194 guest4194
woah, deleted guest4194 guest4194
Testing guest3614 guest3614
guest3614
  1. 
      
  2. Testing

  3. 
      
guest3614
  1. sadsadsadsad

  2. 
      
guest2992
  1. Ship It!
  2. 
      
guest4194
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     

    This looks bad to me.

  3. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     

    woah, deleted

  4. 
      
Loading...