Fix saving the verified issue counter when initializing counters.

Review Request #920 — Created Oct. 18, 2017 and updated

guest2117
Review Board
970cb60...
demo
abcd, kksksk
When initializing counters for an older review request, we populate the
counter for the number of verified issues, but then we don't save it
along with the other counters. Unit tests didn't catch this, since the
comprehensive set of issue counter tests didn't check for verification
state changes.

This change fixes that logic and fleshes out the counter tests to make
sure that issue status changes are respected.

Testing Done:
Unit tests pass.

The original issue encountered (during debugging of doc building) has
been fixed.

Reviewed at https://reviews.reviewboard.org/r/9240/


  • 7
  • 0
  • 11
  • 1
  • 19
Description From Last Updated
dqw dqw dqw dqw dqw guest9222 guest9222
my comment guest761 guest761
????????? guest2052 guest2052
wqdqwdqwd guest9222 guest9222
This is a very bad new code line !!!!einself!!! guest2530 guest2530
this is a comment on an unchanged line guest3854 guest3854
Yet another test comment!!! guest2197 guest2197
guest2117
  1. 
      
  2. No need to assert this

  3. 
      
guest2117
Review request changed

People:

-kkkk
+kksksk
guest1629
guest640
  1. sss

  2. 
      
guest4695
  1. Ship It!
  2. 
      
guest5346
  1. Ship It!
  2. 
      
guest5292
  1. Some things to fix yet.

  2. This look real good with hanging comma.

  3. Use plain assert

  4. 
      
guest7000
  1. Ship It!
  2. 
      
guest7000
  1. Ship It!
  2. 
      
guest9753
  1. 
      
  2. ???????

  3. 
      
guest1157
  1. Ship It!
  2. 
      
guest724
guest724
  1. Ship It!
  2. 
      
guest724
guest724
guest724
  1. Ship It!
  2. 
      
guest8861
  1. yeah, ship it!!!

  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    test comment

  3. 
      
guest9467
  1. Ship It!
  2. 
      
guest1387
  1. Ship It!
  2. 
      
guest761
guest83
  1. Inviala!
  2. 
      
guest6021
  1. 
      
  2. general comment

  3. general comment

  4. 
      
guest2530
  1. 
      
  2. This is a very bad new code line !!!!einself!!!

  3. 
      
guest1371
  1. zukhdjd

  2. 
      
guest1371
  1. Ship It!
  2. 
      
guest2609
guest7522
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    Looks good, but probably doesn't taste good.

  3. 
      
guest8913
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    garbage

  3. 
      
guest6032
  1. I guess it's ok

  2. 
      
guest2052
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    ?????????

  3. 
      
guest2052
  1. 
      
  2. not ok a sister jingjing

  3. 
      
guest2052
guest4798
  1. Ship It!

  2. 
      
guest3854
  1. 
      
  2. this is a comment on an unchanged line

  3. 
      
guest4563
  1. Ship It!
  2. 
      
guest4563
  1. Ship It!
  2. 
      
guest2197
  1. 
      
  2. Yet another test comment!!!

  3. 
      
guest1291
guest9222
  1. Ship It!
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    dqw dqw dqw dqw dqw

  3. 
      
Loading...