Fix saving the verified issue counter when initializing counters.

Review Request #920 — Created Oct. 18, 2017 and updated

guest2117
Review Board
970cb60...
demo
abcd, kksksk
When initializing counters for an older review request, we populate the
counter for the number of verified issues, but then we don't save it
along with the other counters. Unit tests didn't catch this, since the
comprehensive set of issue counter tests didn't check for verification
state changes.

This change fixes that logic and fleshes out the counter tests to make
sure that issue status changes are respected.

Testing Done:
Unit tests pass.

The original issue encountered (during debugging of doc building) has
been fixed.

Reviewed at https://reviews.reviewboard.org/r/9240/


Description From Last Updated

general comment

guest6021guest6021

Nice work

guest964guest964

my issue is with the issue

guest964guest964

boq

guest1291guest1291

this code is abysmmal. javascript uses === not ==

guest7067guest7067

dqw dqw dqw dqw dqw

guest9222guest9222

test comment

guest8861guest8861

my comment

guest761guest761

?????????

guest2052guest2052

garbage

guest8913guest8913

Looks good, but probably doesn't taste good.

guest7522guest7522

What?

guest2609guest2609

Not correct

guest2117guest2117

wqdqwdqwd

guest9222guest9222

not ok a sister jingjing

guest2052guest2052

Are you sure ?

guest6827guest6827

why?

guest2052guest2052

This is a very bad new code line !!!!einself!!!

guest2530guest2530

{insert flaming here}

guest964guest964

wtf?

guest8861guest8861

No need to assert this

guest2117guest2117

this is a comment on an unchanged line

guest3854guest3854

This is bad

guest1977guest1977

Yet another test comment!!!

guest2197guest2197

test

guest724guest724
guest2117
  1. 
      
  2. No need to assert this

  3. 
      
guest2117
Review request changed

People:

-kkkk
+kksksk
guest1629
guest640
  1. sss

  2. 
      
guest4695
  1. Ship It!
  2. 
      
guest5346
  1. Ship It!
  2. 
      
guest5292
  1. Some things to fix yet.

  2. This look real good with hanging comma.

  3. Use plain assert

  4. 
      
guest7000
  1. Ship It!
  2. 
      
guest7000
  1. Ship It!
  2. 
      
guest9753
  1. 
      
  2. ???????

  3. 
      
guest1157
  1. Ship It!
  2. 
      
guest724
guest724
  1. Ship It!
  2. 
      
guest724
guest724
guest724
  1. Ship It!
  2. 
      
guest8861
  1. yeah, ship it!!!

  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    test comment

  3. 
      
guest9467
  1. Ship It!
  2. 
      
guest1387
  1. Ship It!
  2. 
      
guest761
guest83
  1. Inviala!
  2. 
      
guest6021
  1. 
      
  2. general comment

  3. general comment

  4. 
      
guest2530
  1. 
      
  2. This is a very bad new code line !!!!einself!!!

  3. 
      
guest1371
  1. zukhdjd

  2. 
      
guest1371
  1. Ship It!
  2. 
      
guest2609
guest7522
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    Looks good, but probably doesn't taste good.

  3. 
      
guest8913
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    garbage

  3. 
      
guest6032
  1. I guess it's ok

  2. 
      
guest2052
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    ?????????

  3. 
      
guest2052
  1. 
      
  2. not ok a sister jingjing

  3. 
      
guest2052
guest4798
  1. Ship It!

  2. 
      
guest3854
  1. 
      
  2. this is a comment on an unchanged line

  3. 
      
guest4563
  1. Ship It!
  2. 
      
guest4563
  1. Ship It!
  2. 
      
guest2197
  1. 
      
  2. Yet another test comment!!!

  3. 
      
guest1291
guest9222
  1. Ship It!
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    dqw dqw dqw dqw dqw

  3. 
      
guest6827
  1. 
      
  2. Are you sure ?

  3. 
      
guest6827
  1. 
      
  2. 
      
guest7067
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    this code is abysmmal. javascript uses === not ==

  3. 
      
guest7067
  1. Ship It!
  2. 
      
guest7067
  1. Ship It!
  2. 
      
guest7067
  1. Ship It!
  2. 
      
guest7067
  1. 
      
  2. 
      
guest6100
  1. Ship It!
  2. 
      
guest1977
guest6214
  1. 
      
  2. 
      
guest1228
  1. Ship It!
  2. 
      
guest3600
guest8354
  1. Hi

  2. 
      
guest4800
  1. Ship It!
  2. 
      
guest8508
  1. Ship It!
  2. 
      
guest964
  1. 
      
  2. reviewboard/reviews/tests/test_review_request.py (Diff revision 1)
     
     
     
     
     

    {insert flaming here}

  3. 
      
guest964
  1. Ship It!
  2. 
      
guest964
  1. 
      
  2. Nice work

  3. 
      
guest964
  1. 
      
  2. reviewboard/reviews/models/review.py (Diff revision 1)
     
     

    my issue is with the issue

  3. 
      
guest1505
  1. Ship It!
  2. 
      
Loading...