Fix a regression with searching for closed review requests.

Review Request #1024 — Created Dec. 25, 2017 and updated

guest7377
Review Board
1888
08fdb38...
demo
rr
When the search API was rewritten, it was updated to use `public()` in
order to be more secure. This ended up using the default of only
returning opened review requests, excluding any closed ones, regressing
the ability to match those in the quick search results.

This changes that query to not limit results to open review requests,
and adds unit tests to ensure this doesn't regress.

Testing Done:
Unit tests pass. They failed prior to the fix.

Reviewed at https://reviews.reviewboard.org/r/9424/

ttt

Description From Last Updated

Testing functionality

guest6724guest6724

test fix your name

guest5302guest5302

This comment is quite cool

guest6724guest6724

This might be good to move to another place.

guest6724guest6724

test

guest1054guest1054

This is a test comment. Do this a different way.

guest8017guest8017

line 495

guest3207guest3207

very good

guest1165guest1165
guest8017
  1. After reviewing the code, it looks good except for a few things. See comments.

  2. reviewboard/webapi/tests/test_search.py (Diff revision 1)
     
     

    This is a test comment. Do this a different way.

  3. 
      
guest6724
  1. test

  2. Testing functionality

  3. 
      
guest6724
  1. Ship It!
  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    This comment is quite cool

  3. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    This might be good to move to another place.

  4. 
      
guest9002
  1. Ship It!
  2. 
      
guest3207
  1. overall good stuff

  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    test comment on a line

  3. reviewboard/webapi/tests/test_search.py (Diff revision 1)
     
     

    line 495

  4. 
      
guest558
  1. 
      
  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     
    123
  3. 
      
guest5302
  1. 
      
  2. test fix your name

  3. 
      
guest1165
  1. 
      
  2. reviewboard/webapi/tests/test_search.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    very good

  3. 
      
guest8726
  1. Ship It!
  2. 
      
guest1054
  1. Ship It!
  2. 
      
guest1054
  1. Ship It!
  2. 
      
Loading...