-
-
reviewboard/webapi/tests/test_search.py (Diff revision 1) This is a test comment. Do this a different way.
Fix a regression with searching for closed review requests.
Review Request #1024 — Created Dec. 25, 2017 and updated
Information | |
---|---|
guest7377 | |
Review Board | |
1888 | |
08fdb38... | |
Reviewers | |
demo | |
rr |
When the search API was rewritten, it was updated to use `public()` in order to be more secure. This ended up using the default of only returning opened review requests, excluding any closed ones, regressing the ability to match those in the quick search results. This changes that query to not limit results to open review requests, and adds unit tests to ensure this doesn't regress. Testing Done: Unit tests pass. They failed prior to the fix. Reviewed at https://reviews.reviewboard.org/r/9424/
ttt
Description | From | Last Updated |
---|---|---|
Testing functionality |
|
|
test fix your name |
|
|
ooo |
|
|
0000000000000 |
|
|
This comment is quite cool |
|
|
This might be good to move to another place. |
|
|
test |
|
|
default parameter, wirklich nötig? |
|
|
dfg |
|
|
This is a test comment. Do this a different way. |
|
|
line 495 |
|
|
very good |
|
|
yxyx |
|
-
Ship It!
-
-
reviewboard/webapi/resources/search.py (Diff revision 1) This might be good to move to another place.