Reviews
Diff

- Download Diff

Summary:

Fix a regression with searching for closed review requests.

Review Request #1024 — Created Dec. 25, 2017 and updated Jan. 19, 2021, 11:15 a.m.

Information
Owner:	guest7377
Repository:	Review Board
Branch:
Bugs:
Depends On:
Blocks:	1888
Commit:	08fdb38...
Reviewers
Groups:	demo
People:	rr

Description

When the search API was rewritten, it was updated to use `public()` in
order to be more secure. This ended up using the default of only
returning opened review requests, excluding any closed ones, regressing
the ability to match those in the quick search results.

This changes that query to not limit results to open review requests,
and adds unit tests to ensure this doesn't regress.

Testing Done:
Unit tests pass. They failed prior to the fix.

Reviewed at https://reviews.reviewboard.org/r/9424/

Testing Done

ttt

Issues

Description	From	Last Updated
Testing functionality	guest6724	Jan. 5, 2018, 2:31 p.m.
test fix your name	guest5302	March 4, 2020, 2:20 a.m.
ooo	guest984	Jan. 13, 2021, 7:35 a.m.
0000000000000	guest984	Jan. 13, 2021, 7:37 a.m.
This comment is quite cool	guest6724	Jan. 5, 2018, 2:31 p.m.
This might be good to move to another place.	guest6724	Jan. 5, 2018, 2:30 p.m.
test	guest1054	March 25, 2020, 6:29 p.m.
default parameter, wirklich nötig?	guest9172	July 31, 2020, 7:20 a.m.
dfg	guest9172	July 30, 2020, 9:38 a.m.
This is a test comment. Do this a different way.	guest8017	Dec. 27, 2017, 7:23 p.m.
line 495	guest3207	Jan. 24, 2018, 2:46 p.m.
very good	guest1165	March 5, 2020, 4:02 a.m.
yxyx	guest9172	July 31, 2020, 7:21 a.m.

Fix it!

After reviewing the code, it looks good except for a few things. See comments.

reviewboard/webapi/tests/test_search.py (Diff revision 1)
Show all issues
```
This is a test comment. Do this a different way.
```

```
test
```
Show all issues
```
Testing functionality
```

Ship it! Fix it!

```
Ship It!
```
reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
This comment is quite cool
```
reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
This might be good to move to another place.
```

Ship it!

```
Ship It!
```

Fix it!

```
overall good stuff
```
reviewboard/webapi/resources/search.py (Diff revision 1)
```
test comment on a line
```
reviewboard/webapi/tests/test_search.py (Diff revision 1)
Show all issues
```
line 495
```
1. guest710 Jan. 24, 2018, 10:42 p.m.

reviewboard/webapi/resources/search.py (Diff revision 1)
```
123
```

Fix it!

Show all issues
```
test fix your name
```

Fix it!

reviewboard/webapi/tests/test_search.py (Diff revision 1)

Show all issues

very good

Ship it!

```
Ship It!
```

Ship it! Fix it!

```
Ship It!
```
reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
test
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
dfg
```

reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
default parameter, wirklich nötig?
```
1. guest9172 July 31, 2020, 7:22 a.m.
  kjsdkjlsdkl
reviewboard/webapi/tests/test_search.py (Diff revision 1)
Show all issues
```
yxyx
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Fix it!

Show all issues
```
ooo
```

Fix it!

```
111111111111111111111
```
reviewboard/webapi/resources/search.py (Diff revision 1)
Show all issues
```
0000000000000
```

Ship it!

Double checked the code with the coding standard. It is complying.

The coding standard for our organisation was not fully followed in this case.

Loading...