Reviews
Diff

- Download Diff

Summary:

Merge branch 'release-3.0.x'

Review Request #1031 — Created Jan. 8, 2018 and updated Nov. 8, 2018, 10:52 p.m.

Information
Owner:	guest9002
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	caacf59...
Reviewers
Groups:	demo
People:	Some, steve

Description

Merge branch 'release-3.0.x' (Please oh lord check it)

Testing Done

Issues

Description	From	Last Updated
??? ?? ??????	guest6594	Oct. 23, 2018, 2:36 p.m.
You forgot to account for this down below.	guest3325	Nov. 8, 2018, 10:52 p.m.
LGTM	guest4114	Oct. 23, 2018, 10:15 p.m.
???????? ???	guest6594	Oct. 23, 2018, 2:36 p.m.
I like the old way better.	guest1757	Sept. 18, 2018, 2:31 p.m.

Ship it!

```
Ship It!
```

reviewboard/staticbundles.py (Diff revision 1)
Show all issues
```
I like the old way better.
```
1. guest1757 Sept. 18, 2018, 2:32 p.m.
  No, sorry. We are leaving this change in.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

reviewboard/reviews/tests/test_review_request_updates_view.py (Diff revision 1)
Show all issues
```
??? ?? ??????
```
1. guest6336 Oct. 30, 2018, 3:48 a.m.
  what's color ?
reviewboard/reviews/views.py (Diff revision 1)
Show all issues
```
???????? ???
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```
reviewboard/reviews/tests/test_views.py (Diff revision 1)
Show all issues
```
LGTM
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/reviews/tests/test_review_request_updates_view.py (Diff revision 1)

I don't think you need this - it's going to be deprecated next release.

reviewboard/reviews/tests/test_views.py (Diff revision 1)
Show all issues
```
You forgot to account for this down below.
```
reviewboard/reviews/tests/test_views.py (Diff revision 1)
```
Nice!  I like it.
```
reviewboard/reviews/views.py (Diff revision 1)
```
I like the old way better
```
reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.es6.js (Diff revision 1)
```
Are you sure this is the correct type?
```

Loading...