Add "Publish and Archive" to the review dialog.
Review Request #1041 — Created Jan. 25, 2018 and submitted
Information | |
---|---|
guest1224 | |
Review Board | |
29aa306... | |
Reviewers | |
demo | |
guest1224 |
This change adds a shortcut allowing people who are publishing a review to publish the review and archive the review request all in one shot. Testing done: - Manually tested adding a comment and clicking "Publish and Archive" from the banner. Once published, the review request is marked as archived. Manually tested adding a comment, clicking "Edit Review" from the banner, and clicking "Publish and Archive" from the review dialog view. Once published, the review request is marked as archived. - Added 3 unit tests, which all pass (along with all other tests). One scenario creates a new visit and archives the review request. The other two scenarios update existing visits from visible to visible, and visible to archived. - Added a javascript test to ensure that onPublishClicked is called with the correct values. Reviewed at https://reviews.reviewboard.org/r/9220/
Description | From | Last Updated |
---|---|---|
Comment |
|
|
good |
|
|
perfect |
|
|
yes. that sounds better |
|
|
ok |
|
|
hummm |
|
|
single line comment |
|
|
several line comment |
|
|
japp thats ok |
|
|
ok |
|
|
good enough |
|
|
ok |
|
|
wrong code |
|
|
ok |
|