guest1773 got a fish trophy!

Reviews
Diff

- Download Diff

Summary:

Don't check for hg executable if we're using hgweb.

Review Request #1111 — Created March 6, 2018 and updated June 5, 2019, 12:28 a.m.

Information
Owner:	guest1773
Repository:	Review Board
Branch:
Bugs:
Depends On:
Blocks:	1555
Commit:	93ac356...
Reviewers
Groups:	demo
People:

Description

If a Review Board instance uses hgweb for all communication with Mercurial
repositories, it is not necessary to have a hg executable on that system.

Testing Done:
Removed hg executable from system and saw that a diff can be shown und a new
review request could be opened by post-commit /r/new/

Reviewed at https://reviews.reviewboard.org/r/9708/

Testing Done

Issues

Description	From	Last Updated
A sample general comment	guest8621	June 22, 2018, 2:06 p.m.
it's ok	guest6521	Oct. 18, 2018, 6:27 a.m.
2	guest6594	Oct. 23, 2018, 2:16 p.m.
123	guest6594	Oct. 23, 2018, 2:16 p.m.
123	guest2066	May 30, 2019, 12:16 p.m.
23	guest2066	May 30, 2019, 12:16 p.m.
asdf	guest583	June 13, 2018, 8:43 a.m.
xdfyghvdht sdnh tsdh	guest5150	June 19, 2018, 4:51 p.m.
if code bud	guest1058	May 30, 2019, 1 p.m.
this is broken	guest6763	June 22, 2018, 8:14 a.m.
dont use self.client	guest6115	June 18, 2018, 7:19 a.m.
asdsdafsfda	guest583	June 13, 2018, 8:44 a.m.
aaa	guest7344	June 5, 2019, 12:28 a.m.
TEst COMMENT	guest5150	June 19, 2018, 4:51 p.m.
Really?	guest3011	Nov. 19, 2018, 11:02 p.m.
check here!!	guest348	May 30, 2019, 9:12 a.m.
This is probably not as good as it could be...	guest5479	May 28, 2019, 2:57 p.m.

```
sdfsfdafdsa sdfadfsasdfadfsa sdfa sdfa
```
reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
asdf
```
reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
asdsdafsfda
```

Ship it!

```
Ship It!
```

```
Ship It!
```

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
dont use self.client
```

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
TEst COMMENT
```

Fix it!

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
xdfyghvdht sdnh tsdh
```
1. guest6763 June 22, 2018, 8:13 a.m.
  It's ok.
2. guest5430 June 24, 2018, 3:46 p.m.
  Replying with a markdown comment.
  
  UI feels laggy...
3. guest6521 Oct. 18, 2018, 6:25 a.m.
  ???????

Ship it!

```
Ship It!
```
1. guest6763 June 22, 2018, 8:13 a.m.
  no please

Ship it!

```
Ship It!
```

```
sdf
```

Fix it!

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
this is broken
```

Show all issues
```
A sample general comment
```

Fix it!

Show all issues
```
it's ok
```

Ship it!

```
Ship It!
```

Fix it!

```
1
```
Show all issues
```
2
```
```
3
```

Fix it!

Show all issues
```
123
```

Ship it!

```
Ship It!
```

Fix it!

1. guest313 May 30, 2019, 7:55 a.m.
  ???
reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
Really?
```

```
hekllo
```

Fix it!

reviewboard/scmtools/hg.py (Diff revision 1)

Show all issues

This is probably not as good as it could be...

```
testing
```

Fix it!

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
check here!!
```

Fix it!

```
123
```
Show all issues
```
123
```
Show all issues
```
23
```

Fix it!

reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
if code bud
```

Ship it! Fix it!

```
Ship It!
```
reviewboard/scmtools/hg.py (Diff revision 1)
Show all issues
```
aaa
```

Loading...