Clean up the API extra data access hooks
Review Request #115 — Created Oct. 26, 2016 and updated
Information | |
---|---|
guest3004 | |
Review Board | |
JIRA-1234 | |
f3af594... | |
Reviewers | |
demo | |
The `APIExtraDataAccessHook` has been rewritten to utilize registries for registration and unregistration of callbacks. Tests have been updated for these changes. The documetnation has also been updated and reformatted for clarity. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/8084/
Description | From | Last Updated |
---|---|---|
yes |
|
|
This is test comment |
|
|
I have written the test header, but don't know what to do next |
|
|
this is a test |
|
|
testttttt |
|
|
??? ???? |
|
|
180225002 |
|
|
20180205003 |
|
|
not intuitive to understand |
|
|
somehthing |
|
|
jnkjnkjnkj |
|
|
Blah |
|
|
Testing comments |
|
|
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa |
|
|
Comment to the line 29 |
|
|
This comment created for the red block |
|
|
aaa |
|
|
ah e tal ta bem |
|
|
add validation |
|
|
modify the method. |
|
|
Shocking! |
|
|
very good |
|
|
why so serious ? |
|
|
Needs more cats! |
|
|
Need more egg resource.register_extra_data_access_callback(self.get_extra_data_state) |
|
|
agree |
|
|
Why not let the code formatting tool do this? |
|
|
This should be 4 instead of 3 because...bla bla |
|
|
Delete |
|
|
Implement ASAP! |
|
|
fff |
|
|
comment |
|
-
Try again
-
-
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) ah e tal ta bem
-
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) Testing comments
-
-
reviewboard/extensions/hooks.py (Diff revision 1) Need more egg
resource.register_extra_data_access_callback(self.get_extra_data_state)
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) add validation
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) modify the method.
-
body top helllooo
something
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) test world of world
-
-
tail workld
-
hello world body
-
reviewboard/webapi/base.py (Diff revision 1) On branch master Your branch is up-to-date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: rboard.py
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) Comment to the line 29
-
I try to review
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) This comment created for the red block
-
Ship It!
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) why so serious ?
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) not intuitive to understand
-
-
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1) aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa