- Download Diff

Summary:

Clean up the API extra data access hooks

Review Request #115 — Created Oct. 26, 2016 and updated Feb. 19, 2018, 10:34 p.m.

Information
Owner:	guest3004
Repository:	Review Board
Branch:
Bugs:	JIRA-1234
Depends On:
Commit:	f3af594...
Reviewers
Groups:	demo
People:

Description

The `APIExtraDataAccessHook` has been rewritten to utilize registries
for registration and unregistration of callbacks. Tests have been
updated for these changes.

The documetnation has also been updated and reformatted for clarity.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/8084/

Testing Done

Issues

Description	From	Last Updated
yes	guest1601	Nov. 22, 2016, 7:23 a.m.
This is test comment	guest7973	June 6, 2017, 2:47 a.m.
I have written the test header, but don't know what to do next	guest7384	July 17, 2017, 12:08 p.m.
this is a test	guest6613	Nov. 27, 2017, 8:57 a.m.
testttttt	guest2302	Feb. 5, 2018, 7:40 a.m.
??? ????	guest2302	Feb. 5, 2018, 7:40 a.m.
180225002	guest2302	Feb. 5, 2018, 8:03 a.m.
20180205003	guest2302	Feb. 5, 2018, 8:17 a.m.
not intuitive to understand	guest5739	July 28, 2017, 7:16 p.m.
somehthing	guest1201	July 15, 2017, 7:38 a.m.
jnkjnkjnkj	guest9410	April 23, 2017, 7:52 p.m.
Blah	guest6731	May 26, 2017, 11:33 p.m.
Testing comments	guest6731	May 26, 2017, 11:33 p.m.
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa	guest8943	Feb. 15, 2018, 7:09 p.m.
Comment to the line 29	guest7384	July 17, 2017, 12:17 p.m.
This comment created for the red block	guest7384	July 17, 2017, 12:19 p.m.
aaa	guest8943	Feb. 15, 2018, 7:08 p.m.
ah e tal ta bem	guest3867	Jan. 12, 2017, 2:32 p.m.
add validation	guest6427	July 12, 2017, 7:56 p.m.
modify the method.	guest6427	July 14, 2017, 10:05 a.m.
Shocking!	guest7457	Dec. 5, 2016, 12:27 p.m.
very good	guest6445	July 28, 2017, 8:05 p.m.
why so serious ?	guest6636	July 26, 2017, 11:37 a.m.
Needs more cats!	guest7457	Dec. 5, 2016, 12:27 p.m.
Need more egg resource.register_extra_data_access_callback(self.get_extra_data_state)	guest7973	June 6, 2017, 2:50 a.m.
agree	guest5739	July 28, 2017, 7:19 p.m.
Why not let the code formatting tool do this?	guest4635	April 14, 2017, 4:03 p.m.
This should be 4 instead of 3 because...bla bla	guest1561	April 23, 2017, 10:17 p.m.
Delete	guest7959	Jan. 24, 2017, 2:21 p.m.
Implement ASAP!	guest4409	May 29, 2017, 6:21 a.m.
fff	guest2310	Feb. 19, 2018, 10:35 p.m.
comment	guest6527	Dec. 8, 2016, 12:46 p.m.

Groups:

+	demo

People:

-	moomin

Ship it!

```
hello
```

Fix it!

```
aaa
```
Show all issues
```
yes
```

Ship it!

```
Ship It!
```

Fix it!

```
Try again
```
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
Shocking!
```
1. guest2310 Feb. 19, 2018, 10:33 p.m.
  test
reviewboard/extensions/hooks.py (Diff revision 1)
Show all issues
```
Needs more cats!
```

```
ddd
```
reviewboard/webapi/base.py (Diff revision 1)
Show all issues
```
comment
```
1. guest1338 Dec. 9, 2016, 10:55 a.m.
  Hello, TEST 12092016
2. guest1338 Dec. 9, 2016, 10:56 a.m.
  T

Fix it!

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)

Show all issues

ah e tal ta bem

reviewboard/webapi/base.py (Diff revision 1)
Show all issues
```
Delete
```

Fix it!

reviewboard/extensions/tests.py (Diff revision 1)
Show all issues
```
Why not let the code formatting tool do this?
```

```
okok
```

Fix it!

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
jnkjnkjnkj
```

Fix it!

reviewboard/webapi/base.py (Diff revision 1)
Show all issues
```
This should be 4 instead of 3 because...bla bla
```

```
test
```

Ship it!

```
Ship It!
```

Fix it!

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
Blah
```
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
Testing comments
```

reviewboard/webapi/base.py (Diff revision 1)
Show all issues
```
Implement ASAP!
```

Ship it! Fix it!

```
review it
```
Show all issues
```
This is test comment
```
```
This is test footer
```

Fix it!

reviewboard/extensions/hooks.py (Diff revision 1)

Show all issues

Need more egg

resource.register_extra_data_access_callback(self.get_extra_data_state)

Fix it!

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
add validation
```

Fix it!

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
Show all issues
```
modify the method.
```

Ship it!

```
Ship It!
```

Fix it!

```
body top helllooo
something
```
docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)
```
test

world

of world
```

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)

Show all issues

somehthing

```
tail workld
```

```
tail odd
```

docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst (Diff revision 1)

too long

```
we want a tail
```

reviewboard/extensions/tests.py (Diff revision 1)
```
THe quick brown
```

```
hello world body
```

reviewboard/webapi/base.py (Diff revision 1)

On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   rboard.py