Add an API for commenting on FileDiffs ranges

Review Request #1467 — Created Nov. 20, 2018 and submitted Nov. 20, 2018, 12:48 a.m.

Information
Owner:	guest375
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	d14df94...
Reviewers
Groups:
People:	guest3011

Description

The `ReviewDiffCommentResource` is now capable of creating comments on
FileDiffs with a base FileDiff ID. This allows us to comment on
FileDiffs in commit ranges and keep the context of the base FileDiff.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/10190/

Testing Done

Issues

Description	From	Last Updated
Verification test	guest375	Nov. 20, 2018, 12:44 a.m.
Woo hoo... down the rabit hole we go!	guest375	Nov. 20, 2018, 12:46 a.m.
This needs an else check too.	guest3011	Nov. 20, 2018, 12:40 a.m.
Be sure to test this.	guest3011	Nov. 20, 2018, 12:46 a.m.

reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
Show all issues
```
This needs an else check too.
```
1. guest375 Nov. 20, 2018, 12:35 a.m.
  I beg to differ.
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
Show all issues
```
Be sure to test this.
```
1. guest375 Nov. 20, 2018, 12:35 a.m.
  This is already fixed elsewhere.
2. guest3011 Nov. 20, 2018, 12:47 a.m.
  OK.

reviewboard/webapi/resources/base_comment.py (Diff revision 1)
```
Please verify this is the correct state.
```

docs/manual/glossary.rst (Diff revision 1)

The multi-source-line comment is a cool feature

reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
Show all issues
```
Verification test
```
1. guest3011 Nov. 20, 2018, 12:43 a.m.
  Great, so I cannot mark this fixed. yet you marked my comment fixed.

reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
Show all issues
```
Woo hoo... down the rabit hole we go!
```
1. guest3011 Nov. 20, 2018, 12:46 a.m.
  And I can only reply to this one.

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Add an API for commenting on FileDiffs ranges

Status: Closed (submitted)