Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

Merge branch 'release-2.5.18-security' into release-3.0.x

Review Request #1506 — Created Dec. 17, 2018 and updated Dec. 17, 2018, 8:23 a.m.

Information
Owner:	guest583
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	1d01e4a...
Reviewers
Groups:
People:	foobar, guest583

Description

Merge branch 'release-2.5.18-security' into release-3.0.x

Testing Done

Issues

Description	From	Last Updated
not ok	guest583	Dec. 17, 2018, 8:47 a.m.
ok	guest583	Dec. 17, 2018, 8:23 a.m.
looks fine	guest583	Dec. 17, 2018, 8:23 a.m.
should be removed	guest583	Dec. 17, 2018, 8:23 a.m.
OK	guest583	Dec. 17, 2018, 8:23 a.m.

Fix it!

reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
Show all issues
```
not ok
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
Show all issues
```
ok
```

reviewboard/webapi/resources/validate_diff.py (Diff revision 1)

Show all issues

looks fine

reviewboard/webapi/tests/test_validate_diff.py (Diff revision 1)
Show all issues
```
should be removed
```

reviewboard/webapi/tests/test_validate_diff.py (Diff revision 1)

Show all issues

OK

Loading...