Add support for modern Bitbucket webhooks.
Review Request #1518 — Created Dec. 28, 2018 and updated
Information | |
---|---|
guest9014 | |
Review Board | |
2e9945e... | |
Reviewers | |
demo | |
Our support for Bitbucket webhooks was dependent on their legacy implementation, which they've recently removed. They have a newer model with different configuration requirements, different payload format, and restrictions on the number of commits that are represented. This change updates to work with the new format. We now only accept the modern payload format, using the contained commit information if not marked "truncated", falling back to calling into the Bitbucket API if needed. The instructions have been updated for the new configuration process. A notable change is that we can no longer pre-fill in any information in the configuration form, but instead need users to provide it themselves. Testing Done: Unit tests pass. Manually tested with both truncated and non-truncated push event payloads. Verified that the payloads were parsed correctly and that each commit referencing a review request URL was properly handled. Reviewed at https://reviews.reviewboard.org/r/10344/
No test was done
Description | From | Last Updated |
---|---|---|
test |
|
|
Looks good |
|
|
was wrong with this? |
|
|
Ez nem jo! |
|
|
Just a silly comment |
|
|
just a test |
|
|
I dont like new stuff. Why do we need this? |
|
|
Multiline! |
|
|
Wouldn't it be better to rewrite the whole thing as an email client? |
|
|
AAAAAAAAAAAAAAAAAAAA |
|
|
not bad |
|
-
-
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1) Wouldn't it be better to rewrite the whole thing as an email client?
-
-
reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html (Diff revision 1) AAAAAAAAAAAAAAAAAAAA