- Download Diff

Summary:

Restore the code for adding admin widgets.

Review Request #1519 — Created Dec. 29, 2018 and updated Jan. 22, 2020, 10:36 a.m.

Information
Owner:	guest8567
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	492d94c...
Reviewers
Groups:	demo
People:	robin

Description

The code for adding widgets in the administration UI disappeared due to
a merge earlier this year. This went unnoticed by us until today. This
is a simple change that restores the missing lines.

Testing Done

Issues

Description	From	Last Updated
This needs to be fixed.	guest6845	March 5, 2019, 2:08 a.m.
fix issue	guest7359	March 6, 2019, 8:07 a.m.
hello	guest9660	March 9, 2019, 11:22 p.m.
hello	guest9660	March 9, 2019, 11:22 p.m.
hello	guest9660	March 9, 2019, 11:51 p.m.
hello	guest9660	March 10, 2019, 12:03 a.m.
how does this work?	guest9660	March 10, 2019, 2:01 a.m.
how does this work?	guest9660	March 10, 2019, 2:01 a.m.
how does this work?	guest9660	March 10, 2019, 7:07 a.m.
how does this work?	guest9660	March 10, 2019, 7:07 a.m.
how does this work?	guest9660	March 11, 2019, 3:12 a.m.
how does this work?	guest9660	March 11, 2019, 3:12 a.m.
how does this work?	guest9660	March 11, 2019, 3:13 a.m.
how does this work?	guest9660	March 11, 2019, 3:13 a.m.
how does this work?	guest9660	March 11, 2019, 5:23 a.m.
adsfasd	guest9660	March 11, 2019, 5:33 a.m.
adfasdfasdafsdfasdfad	guest9660	March 11, 2019, 5:36 a.m.
how does this work?	guest9660	March 11, 2019, 5:44 a.m.
how does this work?	guest9660	March 11, 2019, 5:54 a.m.
how does this work?	guest9660	March 11, 2019, 5:55 a.m.
how does this work?	guest9660	March 11, 2019, 5:55 a.m.
how does this work?	guest9660	March 11, 2019, 5:55 a.m.
how does this work?	guest9660	March 11, 2019, 5:55 a.m.
how does this work?	guest9660	March 11, 2019, 5:55 a.m.
Hello	guest8424	May 23, 2019, 7:12 a.m.
Header Header Header Cell Cell Cell Cell Cell Cell	guest2012	June 7, 2019, 4:15 p.m.
	guest3998	Oct. 16, 2019, 7:46 a.m.
test	guest3621	Oct. 16, 2019, 9:51 a.m.
sthfdthdfth	guest2481	Jan. 22, 2020, 10:36 a.m.
lñp,	guest9376	Feb. 26, 2019, 8:36 p.m.
WTF is this	guest9376	March 7, 2019, 4:38 p.m.
????????????????	guest3598	July 30, 2019, 8:09 a.m.
issue	guest8148	May 17, 2019, 6:29 a.m.
where is the issue opened?	guest4001	Oct. 4, 2019, 8:17 p.m.
Header first	guest4001	Oct. 4, 2019, 8:21 p.m.
bar	guest1171	July 29, 2019, 10:14 a.m.
this is wrong	guest4001	Oct. 4, 2019, 8:21 p.m.
foo	guest1171	July 29, 2019, 10:13 a.m.
This is a review comment!!!!!!	guest8424	May 23, 2019, 7:16 a.m.
u sure?	guest7663	May 13, 2019, 10:17 a.m.
way too much code, and it is javascript	guest9452	May 14, 2019, 12:40 a.m.
bar	guest1171	July 29, 2019, 10:14 a.m.
cool	guest6768	March 4, 2019, 1:21 p.m.
another one	guest4001	Oct. 4, 2019, 8:21 p.m.
This is a comment!	guest1963	March 28, 2019, 2:57 p.m.
????	guest3598	July 30, 2019, 8:09 a.m.
??????	guest3598	July 30, 2019, 8:09 a.m.
test	guest3079	Oct. 2, 2019, 12:30 p.m.
test???	guest3600	May 13, 2019, 1:49 p.m.
forth	guest4001	Oct. 4, 2019, 8:21 p.m.

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
```
Does the Width value confirmed with Designer?
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)

Show all issues

WTF is this

guest9376 Feb. 26, 2019, 8:36 p.m.
```
huehue
```
guest136 March 7, 2019, 4:35 p.m.
```
ciaoa
```
guest4091 Jan. 17, 2020, 9:26 p.m.
```
Test
```

Fix it!

1. guest3621 Oct. 16, 2019, 10:15 a.m.
  o
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
lñp,
```
1. guest136 March 7, 2019, 4:35 p.m.
  ciaio

```
dsaf fdsa
```
```
fdsa
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
cool
```
1. guest517 March 11, 2019, 1:51 p.m.
  !!!!

Fix it!

Show all issues
```
This needs to be fixed.
```
1. guest9361 Aug. 8, 2019, 2:49 p.m.
  ok :)

```
Ship It!
```

Show all issues
```
fix issue
```
1. guest517 March 11, 2019, 1:51 p.m.
  sdflksjfljsdlf lsdjf

Show all issues
```
hello
```

Fix it!

Show all issues
```
hello
```

Fix it!

Show all issues
```
hello
```

Fix it!

Show all issues
```
hello
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues

how does this work?

guest3191 Jan. 12, 2020, 4:51 p.m.

Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa quis enim. Donec pede justo, fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Nullam dictum felis eu pede mollis pretium. Integer tincidunt. Cras dapibus. Vivamus elementum semper nisi. Aenean vulputate eleifend tellus. Aenean leo ligula, porttitor eu, consequat vitae, eleifend ac, enim. Aliquam lorem ante, dapibus in, viverra quis, feugiat a, tellus. Phasellus viverra nulla ut metus varius laoreet. Quisque rutrum. Aenean imperdiet. Etiam ultricies nisi vel augue. Curabitur ullamcorper ultricies nisi. Nam eget dui. Etiam rhoncus. Maecenas tempus, tellus eget condimentum rhoncus, sem quam semper libero, sit amet adipiscing sem neque sed ipsum. Nam quam nunc, blandit vel, luctus pulvinar, hendrerit id, lorem. Maecenas nec odio et ante tincidunt tempus. Donec vitae sapien ut libero venenatis faucibus. Nullam quis ante. Etiam sit amet orci eget eros faucibus tincidunt. Duis leo. Sed fringilla mauris sit amet nibh. Donec sodales sagittis magna. Sed consequat, leo eget bibendum sodales, augue velit cursus nunc,

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

```
asdfaesds
```

Fix it!

Show all issues
```
how does this work?
```

```
adsfasd
```

```
asdfasdfasd
```

Fix it!

Show all issues
```
adsfasd
```

Fix it!

Show all issues
```
adfasdfasdafsdfasdfad
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

Fix it!

Show all issues
```
how does this work?
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
This is a comment!
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
u sure?
```

```
test
```

Ship it!

```
test
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
test???
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
way too much code, and it is javascript
```

Ship it!

```
Ship It!
```

```
ship it, as it wont get better...
```

```
???
```
1. guest5155 May 16, 2019, 1:13 a.m.
  ?????...

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
issue
```

Show all issues
```
Hello
```

```
this is a test review
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
This is a review comment!!!!!!
```
1. guest2012 June 7, 2019, 4:21 p.m.
  Is it?

Fix it!

1. guest3191 Jan. 12, 2020, 4:53 p.m.
  bye bye

Show all issues




Header
Header
Header




Cell
Cell
Cell


Cell
Cell
Cell

Header	Header	Header
Cell	Cell	Cell
Cell	Cell	Cell

guest3621 Oct. 16, 2019, 10:14 a.m.
```
yes
```
guest3191 Jan. 12, 2020, 4:53 p.m.
```
ciao ciao
```

Ship it!

```
what's this.
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)

Test comment on multiple line.

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)

have a test

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
foo
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
bar
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
bar
```

Ship it!

```
Ship It!
```

Fix it!

```
??????
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
????????????????
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
????
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
??????
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
```
jquery?
```

```
111111111111111
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
```
test
```

Fix it!

```
header
```
```
general comment
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)

multiline comment

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
test
```
1. guest3079 Oct. 2, 2019, 12:31 p.m.
  reply
```
footer
```
1. guest4001 Oct. 4, 2019, 8:18 p.m.
  no way

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
```
verify
```

Fix it!

```
that is fine
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
where is the issue opened?
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)

Show all issues

Header

first

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
this is wrong
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
another one
```
reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
forth
```

Ship it! Fix it!

```
???
```
Show all issues

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

```
test review3043
```
Show all issues
```
test
```

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
```
This wont work
```

Fix it!

reviewboard/static/rb/js/admin/admin.js (Diff revision 1)
Show all issues
```
sthfdthdfth
```

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Restore the code for adding admin widgets.

!!!!

sdflksjfljsdlf lsdjf

Header