Change Summary:
Changes we've made
Description: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
Review Request #226 — Created Dec. 19, 2016 and updated
Information | |
---|---|
guest7621 | |
Review Board | |
3cfd1fe... | |
Reviewers | |
aaa |
Merge branch 'release-3.0.x'
Added features X, Y, Z
Unit tests
Description | From | Last Updated |
---|---|---|
This is wrong, What you should do is instead DO STUFF |
|
|
MARKDOWN 2020 This is awesome I also Like Numbers Can we do nice links? |
|
|
What if status is not one of the explicitly handled ones? Should you raise an exception? |
|
|
WTF is with the "!(*%!(&^" characters? |
|
|
This is wrong |
|
|
strange |
|
|
why use this? |
|
reviewboard/hostingsvcs/github.py (Diff revision 1) |
---|
This is wrong,
What you should do is insteadDO STUFF
reviewboard/hostingsvcs/github.py (Diff revision 1) |
---|
What if status is not one of the explicitly handled ones? Should you raise an exception?
reviewboard/hostingsvcs/tests/test_github.py (Diff revision 1) |
---|
WTF is with the "!(*%!(&^" characters?