Fix a crash when using Subvertpy 0.11.

Review Request #2289 — Created Oct. 26, 2021 and updated

guest2838
Review Board
fc9d9da...
demo
Subvertpy 0.11 introduced some new logic in `client.propget()` that
normalizes a path to an absolute path. This in turn triggers an eventual
assertion failure in libsvn, which checks to make sure a full repository
URL wasn't passed in (somewhere). This was not a problem in Subvertpy
0.10 (which also didn't have this path normalization).

The problem applies only to `propget()`, and thankfully does not apply
to `proplist()`. To work around this crash, we're now calling
`proplist()` and filtering results from that. This method avoids the
path normalization that broke us, and provides the same results.

The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35

Testing Done:
Unit tests pass on Python 2 and 3, against Subverpty 0.10 and 0.11.

Reviewed at https://reviews.reviewboard.org/r/11725/


Description From Last Updated

No comment needed

guest2838guest2838

Test

guest1211guest1211

Formatting

guest2838guest2838

Fix Formatting

guest2838guest2838
guest2838
  1. 
      
  2. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    No comment needed

  3. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
     
     
     
     

    Fix Formatting

  4. 
      
guest2838
  1. 
      
  2. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
     
     
     

    Formatting

  3. 
      
guest1211
  1. 
      
  2. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
  3. 
      
Loading...