Fix some test skipping issues.

Review Request #2372 — Created Nov. 29, 2021 and updated

guest4588
Review Board
2333
2ed51aa...
guest4588
There are two issues with test skipping that I ran into with my
work-in-progress M1 configuration:

1. Perforce tests were set up to skip if the P4 module wasn't available,
   but at some point we had an import of P4Exception snuck in that
   wasn't properly guarded. This change makes it so that we properly
   skip the test without hitting `ImportError`.
2. Once upon a time, paramiko just allowed `SocketError` to raise when
   port 22 was closed, but now it has its own error class.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/11871/

Ran unit tests
Put it in the dishwasher
Threw it off the building

Description From Last Updated

some comment

guest4588guest4588

ggg

guest5162guest5162
Loading...