Do not use BuiltinLocalsFieldMixin for the DiffCommitListField

Review Request #2428 — Created March 9, 2022 and updated March 18, 2022, 3:06 p.m.

Information
Owner:	guest4865
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	44614b3...
Reviewers
Groups:
People:	bob

Description

The `DiffCommitListField` was using the `BuiltinLocalsFieldMixin` but
not taking advantage of it because it required the data in the actual
review request view as well as in the change description portions. Since
it was building all the data itself anyway, this class no longer uses
the mixin.

Testing Done:
It still works!

Reviewed at https://reviews.reviewboard.org/r/8542/

Testing Done

Issues

Description	From	Last Updated
describe	guest4523	March 18, 2022, 3:06 p.m.
comment from a reviewer	guest8601	March 9, 2022, 2:44 a.m.
fold up	guest4523	March 17, 2022, 11:33 p.m.
this comment requires verification	guest8601	March 9, 2022, 2:44 a.m.
why was this removed	guest8601	March 9, 2022, 2:44 a.m.

Fix it!

reviewboard/reviews/builtin_fields.py (Diff revision 1)
Show all issues
```
comment from a reviewer
```
reviewboard/reviews/views.py (Diff revision 1)
Show all issues
```
this comment requires verification
```

reviewboard/reviews/views.py (Diff revision 1)

Show all issues

why was this removed

Fix it!

reviewboard/reviews/builtin_fields.py (Diff revision 1)
Show all issues
```
fold up
```

Fix it!

reviewboard/reviews/builtin_fields.py (Diff revision 1)
Show all issues
```
describe
```

You have a pending review.

Review Board 4.0.5 alpha 0 (dev)

Do not use BuiltinLocalsFieldMixin for the DiffCommitListField