Do not use BuiltinLocalsFieldMixin for the DiffCommitListField

Review Request #2428 — Created March 9, 2022 and updated

guest4865
Review Board
44614b3...
bob
The `DiffCommitListField` was using the `BuiltinLocalsFieldMixin` but
not taking advantage of it because it required the data in the actual
review request view as well as in the change description portions. Since
it was building all the data itself anyway, this class no longer uses
the mixin.

Testing Done:
It still works!

Reviewed at https://reviews.reviewboard.org/r/8542/


Description From Last Updated

describe

guest4523guest4523

comment from a reviewer

guest8601guest8601

fold up

guest4523guest4523

this comment requires verification

guest8601guest8601

why was this removed

guest8601guest8601
guest8601
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     
     

    comment from a reviewer

  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
     

    this comment requires verification

  4. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     

    why was this removed

  5. 
      
guest4523
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     

    fold up

  3. 
      
guest4523
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     

    describe

  3. 
      
Loading...