Reviews
Diff

- Download Diff

Summary:

Merge branch 'release-2.5.x' into release-3.0.x

Review Request #470 — Created March 14, 2017 and updated Dec. 12, 2019, 11:24 p.m.

Information
Owner:	guest3551
Repository:	Review Board
Branch:
Bugs:	34
Depends On:	2
Commit:	c198b39...
Reviewers
Groups:	demo
People:	aaa

Description

Merge branch 'release-2.5.x' into release-3.0.x

Testing Done

Issues

Description	From	Last Updated
This is a test comment.	guest1536	April 12, 2017, 12:26 p.m.
Venus?	guest3011	Nov. 19, 2018, 11:15 p.m.
blah	guest3011	Nov. 19, 2018, 11:16 p.m.
diff1 comment	guest5837	Nov. 20, 2018, 12:24 a.m.
diff2 comment	guest5837	Nov. 20, 2018, 12:24 a.m.
testtesttesttesttesttest	guest1297	April 18, 2017, 9:17 a.m.
	guest2965	March 16, 2017, 11:50 a.m.
test comment	guest1233	April 10, 2017, 3:57 a.m.
Test	guest2249	April 12, 2017, 7:17 a.m.
??	guest859	Sept. 25, 2019, 10:37 a.m.
Still needed	guest2249	April 12, 2017, 7:17 a.m.
why?	guest2231	Jan. 29, 2019, 5:48 a.m.
aaa	guest6132	Dec. 9, 2019, 12:20 p.m.
Avoid to do this.	guest6157	Sept. 18, 2019, 10:54 a.m.
??222	guest859	Sept. 25, 2019, 10:37 a.m.
Sweet!	guest2493	April 25, 2017, 2:17 p.m.
That's nice code	guest3862	April 21, 2017, 10:01 a.m.
[https://www.google.com] ""Hello Reviewing World""	guest4685	Dec. 12, 2019, 11:24 p.m.
5555	guest1233	April 10, 2017, 4:13 a.m.
whyyy?	guest3862	April 21, 2017, 10:05 a.m.
But what does the fox say??	guest7861	Nov. 21, 2019, 4:24 p.m.
test	guest8348	Oct. 2, 2019, 12:28 p.m.
s?abe	guest6435	Feb. 19, 2019, 9:38 p.m.
asd	guest6435	Feb. 19, 2019, 9:38 p.m.
Test comment	guest9372	April 25, 2017, 10:02 a.m.
Creating a dummy issue for testing purpose..	guest6105	June 19, 2017, 10:10 a.m.
God	guest3719	Nov. 24, 2019, 2:05 a.m.

Depends On:

+	2 - Diff viewer demo

Bugs:

+	34

Groups:

+	demo

Diff:

Revision 2 (+237 -42)

	reviewboard/datagrids/columns.py
	reviewboard/diffviewer/admin.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/tests.py

Ship it!

```
???????
```

Ship it!

```
Ship It!
```

```
hello wpl
```

Ship it!

```
Ship It!
```
1. guest1233 April 10, 2017, 3:57 a.m.
  Bon!

Fix it!

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
1. guest1233 April 10, 2017, 4 a.m.
  ffff
2. guest5987 June 19, 2017, 11:53 a.m.
  sweet, but i want a dog
3. guest5826 Aug. 14, 2019, 9:39 p.m.
  Nice cotton ball

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```
reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
test comment
```

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
5555
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
Test
```

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
Still needed
```

Show all issues
```
This is a test comment.
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
testtesttesttesttesttest
```

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
That's nice code
```

Fix it!

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
whyyy?
```

reviewboard/diffviewer/tests.py (Diff revision 2)
```
this is a comment regarding line 586
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

reviewboard/diffviewer/models.py (Diff revision 2)
Show all issues
```
Test comment
```

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
Sweet!
```

Ship it!

```
Ship It!
```

```
Editing the commetn
```
reviewboard/diffviewer/tests.py (Diff revision 2)
Show all issues
```
Creating a dummy issue for testing purpose..
```

Fix it!

dev-requirements.txt (Diff revision 1)
Show all issues
```
Venus?
```

Fix it!

docs/manual/users/searching/full-text-search.rst (Diff revision 1)
Show all issues
```
blah
```

Fix it!

docs/manual/users/searching/full-text-search.rst (Diff revision 1)
Show all issues
```
diff1 comment
```
docs/manual/users/searching/full-text-search.rst (Diff revision 1)
Show all issues
```
diff2 comment
```

Ship it!

```
Ship It!
```

Ship it!

```
just test
```

Ship it!

```
Ship It!
```

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
why?
```
1. guest2231 Jan. 29, 2019, 5:48 a.m.
  good

Ship it!

```
Ship It!
```

Fix it!

reviewboard/diffviewer/chunk_generator.py (Diff revision 2)
Show all issues
```
s?abe
```
reviewboard/diffviewer/models.py (Diff revision 2)
Show all issues
```
asd
```

Fix it!

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
Avoid to do this.
```

Ship it! Fix it!

```
Ship It!
```
reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
??
```
reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
??222
```

Fix it!

reviewboard/diffviewer/chunk_generator.py (Diff revision 2)

Show all issues

test

```
11
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
But what does the fox say??
```

```
All in all, still needs some work!
```

Fix it!

reviewboard/diffviewer/tests.py (Diff revision 2)
Show all issues
```
God
```

Fix it!

reviewboard/datagrids/columns.py (Diff revision 2)
Show all issues
```
aaa
```

Fix it!

reviewboard/diffviewer/admin.py (Diff revision 2)
Show all issues
```
[https://www.google.com] ""Hello Reviewing World""
```

Loading...