Fix warning for unsaved work on beforeUnload
Review Request #485 — Created March 17, 2017 and updated
| Information | |
|---|---|
| guest822 | |
| Review Board | |
| 176916d... | |
| Reviewers | |
| demo | |
Previously, when editing a review or comments as a user without edit rights, warning users about losing unsaved work did not get displayed. Now the ReviewRequestEditorView's beforeUnload event handler does not check a user's edit rights and only checks to see if any fields are being edited at the moment. New unit tests testing the onBeforeUnload event handler has been added. Testing Done: - Ran JS unit tests. - Check that ReviewDialogView for both edit and non-edit privileged users are warned before unloading. Bugs closed: 4084 Reviewed at https://reviews.reviewboard.org/r/8635/
| Description | From | Last Updated |
|---|---|---|
|
444 |
 guest7326
|
|
|
add general comment |
guest3266
|
|
|
Where is this? |
guest7211
|
|
|
ERROR################ |
guest7055
|
|
|
ffffff |
guest7055
|
|
|
ijnjnj |
guest7780
|
|
|
asdasd asdasdkjkn |
guest4466
|
|
|
asdf |
guest7622
|
|
|
expand |
guest2546
|
|
|
123 |
guest1533
|
|
|
// is code rendered? if ((this.model.get('editable)) { return msg; } header |
guest7668
|
|
|
how about message |
guest2546
|
|
|
Test1 |
guest7324
|
|
|
keep die return statement |
guest3872
|
|
|
This is not this |
guest3703
|
|
|
comment AAA BBB CCC |
guest117
|
|
|
Test2 |
guest7324
|
|
|
This sounds strange.... |
guest7324
|
|
|
Test3 |
guest7324
|
|
|
Test4 |
guest7324
|
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) // is code rendered?
if ((this.model.get('editable)) {
return msg;
}header
-
-
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 1) This sounds strange....
-
-
-
-
-
-
Please fix everything!!!!
-
-
-
-
ffaaa
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) second comment on same line
-
Here my 2€
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) keep die return statement
-
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 1) i don't like this comment
-
Ende