Fix the sample API URL for the WebHooks unit tests.
Review Request #535 — Created March 31, 2017 and updated
Information | |
---|---|
guest6871 | |
Review Board | |
1448466... | |
Reviewers | |
demo | |
The WebHooks unit tests were prefixing each API URL with "api/", which other unit tests don't do. This change simply removes the "api/" prefix. Testing Done: Ran unit tests. Saw that they didn't include the prefix anymore. Reviewed at https://reviews.reviewboard.org/r/8852/
Description | From | Last Updated |
---|---|---|
234r |
|
|
This commit sucks in a way no other commits suck |
|
|
test |
|
|
Test comment |
|
|
How can i comment on specific files ?? |
|
|
Hey |
|
|
test |
|
|
Test |
|
|
ASD |
|
|
Good! |
|
|
I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that ... |
|
|
ggergegergee |
|
|
fsddsffds fdsfdsfsdfds |
|
|
toto |
|
|
test |
|
|
fjfhj |
|
|
This doesnt make any sence |
|
|
trying to create an issue |
|
|
YOu should not strip the api from the uri |
|
|
asdfasdfa sdfa sdf asd fasdf asdf asd fasd fas dfa sdfasdf |
|
|
I like the api.. please mr. don't take it away from me!! :'( |
|
|
If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be ... |
|
|
wtf?! |
|
|
dfffffffffffffffffff |
|
|
abcd |
|
|
Some code |
|
|
resolved one more time. xxx |
|
|
my comment |
|
|
This is a comment |
|
|
Why has this line not changed? |
|
|
jyy |
|
|
22222 |
|
|
ciao |
|
|
3434324324 |
|
|
function test() { console.log('Test failed'); } |
|
|
2222 |
|
|
this is bad |
|
|
this should be tested |
|
|
How can we get a unified diff instead of side-by-side view? |
|
|
Dont strip the api part of the uri it will broke other dependencies * Ok * * Testing 1 2 ... |
|
|
Cooment problem chang what eever |
|
|
null check is missing |
|
|
dd |
|
|
qwe |
|
|
here as well |
|
|
test |
|
|
test2 |
|
-
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) asdfasdfa sdfa sdf asd fasdf asdf
asd
fasd
fas
dfa
sdfasdf -
-
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that multiple lines can be selected. I wish GitHub pull request code reviews had these two features.
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) How can we get a unified diff instead of side-by-side view?
-
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) I like the api.. please mr. don't take it away from me!! :'(
-
Fix that issue and then we should be good!
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be reachable ;)
-
Review testing
-
-
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) YOu should not strip the api from the uri
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) Dont strip the api part of the uri it will broke other dependencies
* Ok *
* Testing
1 2 testing
Reread comment above
- a
- b
- c
-
-
-
reviewboard/webapi/tests/test_webhook.py (Diff revision 1) function test() { console.log('Test failed'); }