- Download Diff

Summary:

Fix the sample API URL for the WebHooks unit tests.

Review Request #535 — Created March 31, 2017 and updated Oct. 16, 2020, 11:48 p.m.

Information
Owner:	guest6871
Repository:	Review Board
Branch:
Bugs:
Depends On:
Commit:	1448466...
Reviewers
Groups:	demo
People:

Description

The WebHooks unit tests were prefixing each API URL with "api/", which
other unit tests don't do. This change simply removes the "api/" prefix.

Testing Done:
Ran unit tests. Saw that they didn't include the prefix anymore.

Reviewed at https://reviews.reviewboard.org/r/8852/

Testing Done

Issues

Description	From	Last Updated
234r	guest7552	Dec. 15, 2017, 2:06 p.m.
This commit sucks in a way no other commits suck	guest9193	Dec. 21, 2017, 10:17 a.m.
test	guest5744	Jan. 31, 2018, 10:54 a.m.
Test comment	guest2904	Feb. 21, 2018, 4:03 a.m.
How can i comment on specific files ??	guest2904	Feb. 21, 2018, 4:03 a.m.
Hey	guest7732	March 8, 2018, 7:56 p.m.
test	guest4917	May 4, 2018, 2:55 a.m.
Test	guest6433	May 9, 2018, 7:22 a.m.
ASD	guest7626	Sept. 17, 2020, 10 a.m.
I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that ...	guest44	Nov. 2, 2017, 10:50 p.m.
ggergegergee	guest1515	May 16, 2018, 3:11 p.m.
fsddsffds fdsfdsfsdfds	guest7751	Jan. 16, 2019, 2:39 a.m.
toto	guest6778	May 29, 2018, 9:43 a.m.
test	guest6887	Jan. 15, 2019, 10:50 a.m.
fjfhj	guest9517	Feb. 2, 2018, 9:26 a.m.
trying to create an issue	guest1661	Dec. 15, 2017, 11:52 p.m.
YOu should not strip the api from the uri	guest2904	Feb. 21, 2018, 4:03 a.m.
asdfasdfa sdfa sdf asd fasdf asdf asd fasd fas dfa sdfasdf	guest7116	Oct. 27, 2017, 8:28 a.m.
I like the api.. please mr. don't take it away from me!! :'(	guest9193	Dec. 21, 2017, 10:16 a.m.
If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be ...	guest9517	Jan. 30, 2018, 3:41 p.m.
wtf?!	guest6778	May 29, 2018, 9:42 a.m.
Some code	guest6871	March 31, 2017, 8:26 a.m.
resolved one more time. xxx	guest7116	Oct. 27, 2017, 8:29 a.m.
my comment	guest9348	Feb. 28, 2018, 6:30 a.m.
This is a comment	guest1256	May 7, 2018, 11:30 a.m.
Why has this line not changed?	guest8835	May 30, 2018, 5:24 a.m.
function test() { console.log('Test failed'); }	guest9348	Feb. 28, 2018, 6:30 a.m.
this is bad	guest4917	May 4, 2018, 2:58 a.m.
this should be tested	guest5575	Nov. 28, 2018, 10:42 a.m.
How can we get a unified diff instead of side-by-side view?	guest44	Nov. 2, 2017, 10:51 p.m.
Dont strip the api part of the uri it will broke other dependencies * Ok * * Testing 1 2 ...	guest2904	Feb. 21, 2018, 4:03 a.m.
Cooment problem chang what eever	guest6449	Dec. 15, 2018, 11:34 a.m.
null check is missing	guest6820	Sept. 21, 2020, 9 a.m.
dd	guest4434	Feb. 20, 2019, 3:01 p.m.
qwe	guest7552	Dec. 15, 2017, 2:06 p.m.
here as well	guest5575	Nov. 28, 2018, 10:42 a.m.
test	guest2967	May 7, 2018, 9:57 p.m.
test2	guest2967	May 7, 2018, 9:57 p.m.

```
Please review it
```

```
Another test
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
Some code
```
1. guest6871 March 31, 2017, 8:25 a.m.
  ok

Ship it!

```
All fine
```

Fix it!

1. guest3217 March 15, 2018, 2:22 p.m.
  i am a comment
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
asdfasdfa sdfa sdf  asd fasdf asdf 

asd

fasd

fas

dfa

sdfasdf
```
1. guest6228 Dec. 21, 2017, 6:09 a.m.
  ??? ? ???????? ????????
2. guest6228 Dec. 21, 2017, 6:10 a.m.
  Ohhh, shit!
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
resolved one more time.  xxx
```
1. guest1140 Dec. 1, 2017, 3:55 a.m.
  do you like it?
  ===============

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
```
csdcxc
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)

Show all issues

I like that RB allows review comments on lines outside the scope of the changed lines. It's also great that multiple lines can be selected. I wish GitHub pull request code reviews had these two features.

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
How can we get a unified diff instead of side-by-side view?
```

Ship it!

```
Ship It!
```

Ship it!

```
fuck it
```

```
that sounds good.
```

Ran unit tests. Saw that they didn't include the prefix anymore.?

```
Ship It!
```

Fix it!

Show all issues
```
234r
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
qwe
```

Fix it!

1. guest4729 Sept. 29, 2020, 8:51 a.m.
  cool
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
trying to create an issue
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
I like the api.. please mr. don't take it away from me!! :'(
```
1. guest3063 Sept. 30, 2020, 7:45 p.m.
  Seems better with the api/

Fix it!

1. guest5693 Feb. 20, 2018, 8:40 p.m.
  that kind of... your opinion

Show all issues

This commit sucks in a way no other commits suck

Fix it!

Fix that issue and then we should be good!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)

Show all issues

If you remove the 'api' prefix, you also have to update the web security classes otherwise no endpoint will be reachable ;)

Show all issues
```
test
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
```
hkhhkjh
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
fjfhj
```

Fix it!

```
Review testing
```
Show all issues
```
Test comment
```
Show all issues
```
How can i comment on specific files ??
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
YOu should not strip the  api from the uri
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)

Show all issues

Dont strip the api part of the uri it will broke other dependencies

* Ok *

* Testing

1 2 testing

Reread comment above
- a
- b
- c

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
my comment
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)

Show all issues


function test() {
    console.log('Test failed');
}

Ship it!

```
Ship It!
```

Fix it!

Show all issues
```
Hey
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Show all issues
```
test
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
this is bad
```
1. guest4917 May 4, 2018, 2:58 a.m.
  ok

```
FIx
```

```
fix
```

```
2134234
```

```
test
```

```
234234
```

```
123
```

Ship it! Fix it!

```
Code Review done
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
This is a comment
```

Ship it!

```
Ship It!
```

Fix it!

This mostly looks good except for the below

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
test
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
test2
```

Fix it!

Show all issues
```
Test
```

Ship it! Fix it!

```
Ship It!
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
ggergegergee
```

Ship it!

```
Ship It!
```

Fix it!

```
my job
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
toto
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
wtf?!
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
Why has this line not changed?
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
this should be tested
```
reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
here as well
```

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
```
foo
```

Ship it!

```
Ship It!
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
Cooment problem

chang 

what eever
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
test
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
fsddsffds

fdsfdsfsdfds
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
dd
```

```
vcvcx
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

```
Test
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Fix it!

Show all issues
```
ASD
```

Fix it!

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
Show all issues
```
null check is missing
```

Ship it!

```
Ship It!
```

```
asdfas
```

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Fix the sample API URL for the WebHooks unit tests.

cool

* Ok *

* Testing

1 2 testing