Summary

File attachment demo

Review Request #1 — Created Sept. 30, 2023 and updated Feb. 9, 2024, 3:08 a.m.

Information

Owner

chipx86

Branch

Bugs

Depends On

Reviewers

Groups

demo

People

Description

Review Board supports attaching and reviewing arbitrary files.

Any file can be attached. Source code outside a repository, test data,
logs, images, PDFs, Word documents, zip files, binary blobs, whatever.

Review UIs

Some types of files have special review UIs, such as Markdown files
and images. They'll also be shown with thumbnails previewing the file.

Using Power Pack, PDF documents can be reviewed and even diffed.

Custom-built extensions can provide new review UIs for the specific files
you need to work with.

Reviewing file attachments

For files that can be reviewed within Review Board, simply click the
thumbnail. Or hover and click Review. You'll be able to leave
comments right on the file, whether text, image, or PDF.

For files Review Board can't display, hover over the thumbnail and
click Download to download the file, or Comment to leave a comment.

Testing Done

Clicked on every one of the files.

Files

Issues

Description	From	Last Updated
We attached a Markdown file above, and are able to comment on both the rendered view and the source.	chipx86	Sept. 30, 2023, 9:46 p.m.
See? Here's the source comment!	chipx86	Sept. 30, 2023, 9:46 p.m.
Comments can also bee left on images. This is really useful when putting up screenshots of new features. Reviewers can …	chipx86	Sept. 30, 2023, 9:46 p.m.
And on diffs of images.	chipx86	Sept. 30, 2023, 9:46 p.m.
And diffs of text-based file attachments.	chipx86	Sept. 30, 2023, 9:46 p.m.
Clean up this mess	guest6312	Oct. 10, 2023, 11:51 p.m.
Remove this line	guest6312	Oct. 10, 2023, 11:51 p.m.
sample comment 2	guest6312	Oct. 10, 2023, 11:51 p.m.
not bad	guest3580	Feb. 9, 2024, 3:08 a.m.

Fix it!

Just like with diffs, you can leave comments directly on file attachments.

guest6353 Oct. 1, 2023, 1:13 p.m.
```
gacor
```

README.md (Revision 2)

1	Review Board
2
3	Review Board is an open source, web-based code and document review tool
4	built to help companies, open source projects, and other organizations keep
5	their quality high and their bug count low.

The issue has been resolved. Show all issues

We attached a Markdown file above, and are able to comment on both the rendered view and the source.

README.md (Revision 2)

1	Review Board
2	============
3
4	Review Board is an open source, web-based code and document review tool
5	built to help companies, open source projects, and other organizations keep
6	their quality high and their bug count low.

The issue has been dropped. Show all issues

See? Here's the source comment!

Cute bee (Revision 2)

Comments can also bee left on images.

This is really useful when putting up screenshots of new features. Reviewers can select a region they want to discuss (a block of text, or a new icon, perhaps) and begin a discussion.

An issue was opened. Show all issues

Comments can also bee left on images.

This is really useful when putting up screenshots of new features. Reviewers can select a region they want to discuss (a block of text, or a new icon, perhaps) and begin a discussion.

Image Diff Test (Revisions 1 - 2)
An issue was opened. Show all issues
```
And on diffs of images.
```

README.md (Revisions 1 - 2)

     thousands.
     Information on usage and installation can be found on
-    http://www.reviewboard.org/docs/manual/dev/
+    https://www.reviewboard.org/docs/manual/latest/
     General information on the project is available on
-    http://www.reviewboard.org/
+    https://www.reviewboard.org/

The issue has been resolved. Show all issues

And diffs of text-based file attachments.

```
demo
```

tests.log (Revision 1)

29	confirm = input("Type 'yes' if you would like to try deleting the test database '%s', or 'no' to cancel: " % test_database_name)

The issue has been resolved. Show all issues

sample comment 2

Ship it!

```
Review comments
```

tests.log (Revision 1)

20	File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 89, in handle

The issue has been resolved. Show all issues

Remove this line

tests.log (Revision 1)

   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/__init__.py", line 453, in execute_from_command_line
     utility.execute()
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/__init__.py", line 392, in execute
     self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 51, in run_from_argv
     super(Command, self).run_from_argv(argv)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/base.py", line 222, in run_from_argv
     self.execute(*args, **options.__dict__)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 72, in execute
     super(Command, self).execute(*args, **options)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/base.py", line 255, in execute
     output = self.handle(*args, **options)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 89, in handle
     failures = test_runner.run_tests(test_labels)
   File "/Users/chipx86/src/rb/reviewboard/reviewboard/test.py", line 76, in run_tests
     old_config = self.setup_databases()

The issue has been resolved. Show all issues

Clean up this mess

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Fix it!

tests.log (Revision 1)

   File "./reviewboard/manage.py", line 165, in main
     execute_from_command_line(sys.argv)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/__init__.py", line 453, in execute_from_command_line
     utility.execute()
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/__init__.py", line 392, in execute
     self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 51, in run_from_argv
     super(Command, self).run_from_argv(argv)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/base.py", line 222, in run_from_argv
     self.execute(*args, **options.__dict__)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/commands/test.py", line 72, in execute
     super(Command, self).execute(*args, **options)
   File "/Users/chipx86/buildroots/rb2.0/lib/python2.7/site-packages/Django-1.5.4-py2.7.egg/django/core/management/base.py", line 255, in execute

An issue was opened. Show all issues

not bad