Diff viewer demo

Review Request #2 — Created Sept. 12, 2016 and updated

chipx86
Review Board
master
470, 5, 1264, 613
demo

The Review Board diff viewer is one of the best on the market. It has many ways to help
you look through a change and focus on what's important.

Here's just a few of the features we provide:

  • Detailed file index

    The file index lists all the files modified in the diff, along with a graph showing the
    relative number of inserts, deletes, and replaces.

    The thickness of the ring shows how much of the file is modified (and will be a full red
    or green circle, if the file is deleted or added).

    The colored dots on the side link to the matching changed chunks for that file.

  • Multi-line commenting

    Click a line number, or click and drag down several lines to comment on those lines.

  • Syntax highlighting

    Every diff is syntax-highlighted, making it easier to see, for instance, what's a string
    and what's a reserved keyword.

    This supports highlighting file formats of all kinds.

  • Collapsable diffs

    Diffs are shown collapsed, only showing what changed and the immediate lines around it.

    A header is shown above each change, showing the nearest function or class. Clicking on the
    header will show all unchangedl ines up to that function or class.

    Alternatively, click the [+] 20 to show 20 more lines, or the [+] to show all the lines
    hidden behind that header.

  • Moved code detection

    Significant code changes that move around a file are specially shown with little move flags
    saying where they went to or where they came from. You can rely on these to know that you
    don't need to give that code another look.

    For example, see how the __init__ function was moved in /r/2/diff/

  • Interdiffs

    When reviewing multiple iterations of a change, you can view an "interdiff," the diff
    between two diffs. It's easy to see what has actually changed. For example, see /r/2/diff/1-2/

  • Indentation change indicators

    When code is indented or un-indented, we show it cleanly without showing a full line change.
    These are shown by >>>> and <<<< markers on lines, which you can see in /r/2/diff/ and in
    /r/2/diff/1-2/

    Unlike most diff viewers, you won't have to waste your time examining every line that was
    indented, looking for changes.

    This will even differentiate between spaces and tabs. If someone accidentally indents
    the wrong way, you'll know.

  • See changes made within a line

    When replacing just part of a line, we highlight the changes, making it much easier to see
    the addition of a word, renaming of a variable, or even the accidental removal of a semicolon.

  • Download any file in the diff

    Simply click the little down arrow next to the "Revision" or "New Change" in the diff's
    header to download the full content of either the file on the left-hand side or right-hand
    side.

Click View Diff in the top-right to look at the diff for this review request
to play around with the diffs.



Description From Last Updated

test

guest7613guest7613

typo

guest172guest172

What this means?

guest172guest172

Cooltoo

guest1181guest1181

error!

guest1903guest1903

This is a bug(test)

guest1903guest1903

testing fix it then ship it

guest3602guest3602

this is my comment

guest1771guest1771

test comment

guest2870guest2870

Test

guest9133guest9133

comment

guest1240guest1240

Your face is full of cheddar.

guest8839guest8839

1

guest2717guest2717

????????????

guest9599guest9599

amazing

guest7301guest7301

Test comment2

guest9175guest9175

Test comment 3

guest9175guest9175

change this one @@@@@@@@@@@@@@@

guest9476guest9476

why was this moved

guest5837guest5837

hi

guest2381guest2381

stuff

guest2083guest2083

This is my comment

guest2269guest2269

Why are we doing this?

guest2060guest2060

181-184????

guest5773guest5773

Missing class java doc.

guest4279guest4279

this is something

guest2381guest2381

test

guest2650guest2650

this is test comment

guest3566guest3566

Entering a comment.

guest3461guest3461

aaa

guest7440guest7440

Hmm

guest5603guest5603

Why do you move this

guest172guest172

Delete this unneccesary crap.

guest3338guest3338

why delete it?

guest7301guest7301

New Comment

guest3461guest3461

what is this?

guest7158guest7158

test

guest4495guest4495

sss

guest9400guest9400

This is a bug!

guest1022guest1022

test

guest5087guest5087

===== this is an issue =====

guest2083guest2083

mmm

guest7440guest7440

rrrrr

guest1841guest1841

hi

guest459guest459

foobar

guest5801guest5801

hello

guest2381guest2381

‘’ ‘’

guest7440guest7440

Test require verification comment.

guest5872guest5872

This looks great

guest172guest172

YO MOMMA

guest8839guest8839

ggg

guest7440guest7440

Can selected rows.Great~

guest1094guest1094

This is test!!

guest3273guest3273

;ll;l;l

guest9445guest9445

asdf

guest7568guest7568

Test issue

guest8285guest8285

Hey, I like this!

guest2023guest2023

This text is italic

guest2676guest2676

test2

guest2650guest2650

remove this line

guest4756guest4756

Just Wrong!

guest5572guest5572

probme

guest3566guest3566

this is a bug plese fix it

guest5109guest5109

wait, what?

guest9373guest9373

This text is not necessary - please revise it to make it shorter.

guest1435guest1435

2323232

guest686guest686

1

guest686guest686

test issue

guest6255guest6255

remove that code

guest1129guest1129

Bad

guest1181guest1181

why change new_value to 'old' in info:?

guest5352guest5352

nice!

guest2276guest2276

change the logic.

guest6427guest6427

333333

guest686guest686

What is this, can you explain to me?

guest7767guest7767

Fix this.

guest7812guest7812

Comments can be made across multiple lines. You might even want to suggest code, like: if value is not None: ...

chipx86chipx86

This is weird. check again

guest3377guest3377

Where the hell is the else branch??? Come imedeatly to my office

guest1841guest1841

asdfasdfasdfasdf

guest506guest506

Surely this shouldn't be here This text has a link to wikipedia

guest8979guest8979

Looking good.

guest9214guest9214

just for test

guest2078guest2078

Test multi-line comment!

guest5087guest5087

fdasfd

guest5572guest5572

my comment import os os.path.exist()

guest7723guest7723

ooooooooooooh

guest459guest459

jhgkjhgk

guest956guest956

hi

guest2381guest2381

not sure if this is a good idea. :)

guest3509guest3509

test 123

guest8397guest8397

asfdasdfsaf

guest5572guest5572

Comments are unclear

guest2197guest2197

You forgot to update this too.

guest1977guest1977

Is this method really still needed?

guest3004guest3004

test

guest6108guest6108

What's wrong with this though?

guest8979guest8979

This is obviously wrong.

guest2955guest2955

fatal bug(markdown)

guest1903guest1903

better not.

guest3065guest3065

old value

guest3065guest3065

oh this is a pain in the tucus!!

guest4592guest4592

pickle riiiiiiiiiiiiick

guest1162guest1162
chipx86
Review request changed

Commit:

+1f6923b96ee8b096ac1411ee4cb1642850bf814b

Diff:

Revision 2 (+25 -29)

Show changes

chipx86
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     

    Comments can be made across multiple lines.

    You might even want to suggest code, like:

    if value is not None:
        # The rest of the code would go here...
        value_html = ...
    

    Note also how this comment opens an issue. We can use this to track what work still needs to be done on the diff.

    1. We can then have a discussion on it. Maybe I think this code is better:

      if not (not value):
          ...
      
    2. Double negative? You're fired!

    3. poop

  3. 
      
guest5572
guest5572
guest5572
guest1394
  1. what a crazy thing

  2. 
      
guest1394
  1. Ship It!
  2. 
      
guest1841
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Where the hell is the else branch??? Come imedeatly to my office

  4. Somebody cannot write

guest7613
guest3509
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    not sure if this is a good idea. :)

  3. 
      
guest3940
  1. 
      
  2. 
      
guest3940
  1. Ship It!
  2. 
      
guest5574
  1. Ship It!
  2. 
      
guest5574
  1. Ship It!
  2. 
      
guest2078
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     

    just for test

  3. 
      
guest5603
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest459
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    ooooooooooooh

  4. 
      
guest5109
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    this is a bug plese fix it

  3. 
      
guest2269
  1. Ship It!
  2. 
      
guest2269
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
     
     

    This is my comment

  3. 
      
guest2269
  1. Ship It!
  2. 
      
guest6931
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     

    Why did u delete these?

  4. 
      
guest172
guest172
  1. 
      
  2. What this means?

  3. 
      
guest172
  1. Reveiw 1

  2. 
      
guest172
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Why do you move this

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     

    This looks great

  4. 
      
guest1022
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    This is a bug!

  3. 
      
guest9373
  1. j

  2. 
      
guest9373
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    wait, what?

  3. 
      
guest9373
  1. Ship It!
  2. 
      
guest3004
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
    Is this method really still needed?
  3. 
      
guest4495
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest4495
  1. Ship It!
  2. 
      
guest3377
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     

    This is weird. check again

  3. 
      
guest3965
  1. Ship It!
  2. 
      
guest2759
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test

  3. 
      
guest2759
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test123

  3. 
      
guest2023
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Hey, I like this!

  3. 
      
guest9613
  1. Ship It!
  2. 
      
guest5643
guest7208
  1. test

  2. 
      
guest617
  1. ok

  2. 
      
guest1181
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest1181
  1. Cool

  2. Cooltoo

  3. 
      
guest5572
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     

    Just Wrong!

  3. 
      
guest5572
  1. Ship It!
  2. 
      
guest2267
  1. test

  2. 
      
guest956
  1. Interesting...

  2. 
      
guest956
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    This shouldn't be here.
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    jhgkjhgk

  4. 
      
guest3273
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    This is test!!

  3. 
      
guest3273
guest1805
  1. Ship It!
  2. 
      
guest1805
  1. Ship It!
  2. 
      
guest9445
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     

    ;ll;l;l

  3. 
      
guest5087
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Test multi-line comment!

  4. 
      
guest6108
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
  3. 
      
guest5352
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    why change new_value to 'old' in info:?

  3. 
      
guest8223
  1. Ship It!
  2. 
      
guest7568
  1. added a comment

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
  3. 
      
guest1903
  1. test for review

  2. 
      
guest1903
  1. 
      
  2. This is a bug(test)

  3. 
      
guest1903
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    fatal bug(markdown)

  3. 
      
guest1903
  1. Ship It!
  2. 
      
guest8979
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     

    Surely this shouldn't be here

    This text has a link to wikipedia

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     

    What's wrong with this though?

    1. HEYYYYY Here's some C++:

      uint32_t someNum = 0;
      if (someNum == 0) {
        printf("What the\n");
      }
      
  4. 
      
guest506
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     

    asdfasdfasdfasdf

  3. 
      
guest9302
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test code in lists:

    • List item
    • Another list item

      Code in list
      
    • More list items

  3. 
      
guest1094
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    Can selected rows.Great~

  3. 
      
guest2283
  1. Ship It!
  2. 
      
guest2283
guest8106
  1. Test!

  2. 
      
guest3566
  1. Ship It!
  2. 
      
guest3566
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    this is test comment

  3. 
      
guest3566
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest3602
  1. Ship It!
  2. testing fix it then ship it

    1. you write the review/comments but don't publish. Click Ship It to publish

  3. 
      
guest2922
  1. dupa

  2. 
      
guest8285
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test issue

  3. 
      
guest5801
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest1771
  1. Ship It!
  2. 
      
guest1771
  1. 
      
  2. this is my comment

  3. 
      
guest2127
  1. 
      
  2. 
      
guest2127
  1. 
      
  2. 
      
guest2127
  1. Ship It!
  2. 
      
guest627
  1. Ship It!
  2. 
      
guest6255
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    test issue

  3. 
      
guest6255
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    test commentz

  3. 
      
guest4279
  1. Class has no java doc

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Missing class java doc.

  3. 
      
guest2870
  1. test rev

  2. 
      
guest2870
  1. 
      
  2. test comment

  3. 
      
guest3461
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    Entering a comment.

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     

    New Comment

  4. 
      
guest9214
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Looking good.

  3. 
      
guest4039
  1. Ship It!
  2. 
      
guest9133
guest9133
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Test

  3. 
      
guest3338
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Delete this unneccesary crap.

  3. 
      
guest5438
  1. Ship It!
  2. 
      
guest7767
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    What is this, can you explain to me?

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     

    lol

  4. 
      
guest7767
  1. Ship It!
  2. 
      
guest1415
  1. Ship It!
  2. 
      
guest1415
  1. Ship It!
  2. 
      
guest7882
  1. This is a test reviewww commets
    1) comment
    2) comment
    3) comment

  2. 
      
guest4587
  1. Ship It!

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    test comment

  3. <p>Thanks</p>

guest1240
guest1129
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    remove that code

  3. 
      
guest4756
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    remove this line

  3. 
      
guest838
  1. 
      
  2. 
      
guest838
  1. 
      
  2. 
      
guest838
  1. Ship It!
  2. 
      
guest8839
  1. 
      
  2. 
      
guest8839
  1. Banana boat

  2. Your face is full of cheddar.

  3. 
      
guest8839
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     

    YO MOMMA

  3. 
      
guest8839
  1. Ship It!
  2. 
      
guest4732
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
     
     

    test

  3. 
      
guest6427
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    change the logic.

  3. 
      
guest2717
  1. Ship It!
  2. 
      
guest2717
  1. xqqqqqqq

  2. 
      
guest2676
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    This text is italic

  3. 
      
guest686
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    2323232

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
  4. 
      
guest9599
  1. 
      
  2. ????????????

  3. 
      
guest1162
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    pickle riiiiiiiiiiiiick

  3. 
      
guest2381
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     

    this is something

  3. 
      
guest2381
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
     
     
     
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  4. 
      
guest2381
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
  3. 
      
guest2650
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
  4. 
      
guest4592
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    oh this is a pain in the tucus!!

  3. 
      
guest2318
  1. Ship It!

  2. 
      
guest5047
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    just teset how

  3. 
      
guest5047
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     

    this is a good tool

  3. 
      
guest2276
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. 
      
guest7158
guest7158
  1. Ship It!
  2. 
      
guest3433
  1. hallo

  2. 
      
guest3065
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    better not.

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     

    old value

  4. 
      
guest7888
  1. Please fix it

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    test if info['new'][0] has valid value befor use

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    old_lines, new_lines - check values before pass to differ

  4. 
      
guest8628
  1. Ship It!
  2. 
      
guest8397
  1. whats up

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    test 123

  3. 
      
guest9400
  1. Ship It!
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
  3. 
      
guest2362
  1. 
      
  2. bleh

  3. 
      
guest2197
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     
     
     

    Comments are unclear

  3. 
      
guest2083
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
     
     
     
     
     
  3. 
      
guest2083
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    ===== this is an issue =====

  3. 
      
guest7440
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
  4. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    ‘’
    ‘’

  5. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
  6. 
      
guest7440
  1. Ship It!
  2. 
      
guest9476
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     
     

    change this one @@@@@@@@@@@@@@@

  3. 
      
guest9476
  1. 
      
  2. 
      
guest7301
  1. 
      
  2. amazing

  3. 
      
guest7301
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    why delete it?

  3. 
      
guest1435
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     
     
     

    This text is not necessary - please revise it to make it shorter.

  3. 
      
guest3565
  1. Ship It!
  2. 
      
guest6868
  1. Ship It!
  2. 
      
guest9175
  1. test comment1

  2. Test comment2

  3. Test comment 3

  4. 
      
guest2060
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
     
     
     
     
     
     
     
     
     
     
     

    Why are we doing this?

  3. 
      
guest7723
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    my comment

    import os
    os.path.exist()
    
  3. 
      
guest5773
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     
     
     

    181-184????

  3. 
      
guest5773
  1. 
      
  2. general comment 123123

  3. 
      
guest5773
  1. Ship It!
  2. 
      
guest2316
  1. Ship It!
  2. 
      
guest8159
  1. Ship It!
  2. 
      
guest7812
  1. Looks good overall, some comments below.

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     

    Fix this.

  3. 
      
guest5837
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     

    why was this moved

  3. 
      
guest2955
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    This is obviously wrong.

  3. 
      
guest2896
  1. Ship It!

  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    why

  3. 
      
guest5872
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     
     

    Just a simple comment, no biggie.

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     
     

    Test require verification comment.

  4. 
      
guest5872
  1. Ship It!
  2. 
      
guest1977
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    You forgot to update this too.

  3. 
      
Loading...