• 
      

    FTR: FibonacciHeap.cpp — FIBHEAP_CR_2026

    Review Request #171 — Created June 4, 2026 and discarded

    Information

    Reviewers

    Formal Technical Review: FibonacciHeap.cpp 359 LOC

    
     

    guest5332
    guest5332
    guest5332
    1. [Line 23 - Severe] Subroutine/Module Mismatch: InitializeHeap is declared as 'node InitializeHeap()' but implemented as 'node* InitializeHeap()'. Return type and parameter type are inconsistent, causing a compilation error.

    2. 
        
    guest502
    1. [Line 49 - Severe] Incomplete Item: Missing semicolon after 'np = NULL'. Should be 'np = NULL;'.

    2. 
        
    guest5332
    1. [Line 79 - Severe] Incorrect Item: Extra closing brace causes Insert() to terminate prematurely.

      [Line 83 - Moderate] Missing Item: Fibonnaci_link() has no return statement despite being declared as int.

      [Line 136 - Severe] Variable-type Incorrect: 'node A' should be 'node* A'. Incorrect type declaration for array.

    2. 
        
    guest502
    1. [Line 137 - Severe] Variable-type Incorrect: 'ptr = p' is a type mismatch. Should be 'node* ptr = p'.

      [Line 155 - Severe] Forgotten Cases or Steps: do-while structure is malformed. Missing closing brace before 'while' condition.

      [Line 170 - Moderate] Operator Incorrect: Bitwise AND '&' used instead of logical AND '&&' in conditional expression.

      [Line 171 - Severe] Iterating Loop Incorrectly: for loop uses 'i--' causing infinite loop. Should be 'i++'.

      [Line 181 - Moderate] Variable-type Incorrect: Non-standard VLA 'int A[H->n]' used. Should use 'vector<node*> A(D+1)'.

      [Line 197 - Severe] Incomplete Item: Malformed while block. Missing opening brace after while condition.

    2. 
        
    guest5332
    1. [Line 245 - Severe] Inconsistent Subroutine Arguments: Decrease_key declared as 'int Decrease_key(node*, int, int)' but implemented with incorrect parameter types.

    2. 
        
    guest502
    1. [Line 270 - Moderate] Missing Item: Find() is missing a return statement on one execution path.

      [Line 300 - Moderate] Missing Item: Cut() has no return statement despite being declared as int.

      [Line 317 - Severe] Incomplete Item: Cascase_cut() is missing closing brace, causing scope error.

    2. 
        
    guest5332
    1. [Line 328 - Severe] Incomplete Item: 'return p' is missing a semicolon. Should be 'return p;'.

      [Line 347 - Moderate] Referenced Wrong Data Variable: Uses 'H' instead of 'H1' in Display(). Wrong variable referenced.

      [Line 351 - Severe] Incorrect Item: cout syntax error. '< endl' should be '<< endl'.

      [Line 223 - Moderate] Referenced Wrong Data Variable: Union() references 'H' instead of 'H1', causing incorrect heap operations.

      [Line 100 - Moderate] Missing Condition Test: Union() does not check for empty heap before merging. Should verify H1 and H2 are not NULL.

    2. 
        
    guest5332
    Review request changed
    Status:
    Discarded