• 
      

    Use KeyValueForm getter/setter methods in DiffSettingsForm.

    Review Request #89 — Created June 11, 2025 and updated

    Information

    Review Board
    7421374...

    Reviewers

    The `DiffSettingsForm` has a few things which are handled specially (in
    order to serialize and deserialize certain settings where the UI doesn't
    map trivially to the settings keys). These were written to read and
    write directly from the `siteconfig`.
    
    This change makes it so those use the base `KeyValueForm`
    `get_key_value()` and `set_key_value()` methods instead. The
    implementation of those ends up doing the same thing as the current
    code, but will allow us to subclass this form in RBCommons and override
    those methods to try reading and writing from the `LocalSite` instead.
    
    Testing Done:
    - Ran unit tests.
    - Edited diff settings and verified that it all still worked correctly.
    
    Reviewed at https://reviews.reviewboard.org/r/14436/
    
     
    Description From Last Updated

    This is a bug

    guest6113 guest6113

    Test comment

    guest6113 guest6113
    guest7325
    1. ADDED MANUALLY
      Needs more work.

    2. 
        
    guest2576
    1. 
        
    2. My second commit

    3. My test comment

    4. 
        
    guest2576
    1. Ship It!
    2. 
        
    guest6113
    1. 
        
    2. Show all issues

      This is a bug

    3. This is not an issue

    4. Show all issues

      Test comment

    5.