• 
      

    Diff viewer demo

    Review Request #2 — Created May 21, 2024 and updated

    Information

    Review Board

    Reviewers

    The Review Board diff viewer is one of the best on the market. It has
    many ways to help you look through a change and focus on what's
    important.

    Here's just a few of the features we provide:

    • Detailed file index

      The file index lists all the files modified in the diff, along with a
      graph showing the relative number of inserts, deletes, and replaces.

      The thickness of the ring shows how much of the file is modified (and
      will be a full red or green circle, if the file is deleted or added).

      The colored dots on the side link to the matching changed chunks for
      that file.

    • Multi-line commenting

      Click a line number, or click and drag down several lines to comment
      on those lines.

    • Syntax highlighting

      Every diff is syntax-highlighted, making it easier to see, for
      instance, what's a string and what's a reserved keyword.

      This supports highlighting file formats of all kinds.

    • Collapsable diffs

      Diffs are shown collapsed, only showing what changed and the
      immediate lines around it.

      A header is shown above each change, showing the nearest function or
      class. Clicking on the header will show all unchangedl ines up to
      that function or class.

      Alternatively, click the [+] 20 to show 20 more lines, or the [+]
      to show all the lines hidden behind that header.

    • Moved code detection

      Significant code changes that move around a file are specially shown
      with little move flags saying where they went to or where they came
      from. You can rely on these to know that you don't need to give that
      code another look.

      For example, see how the __init__ function was moved in /r/2/diff/

    • Indentation change indicators

      When code is indented or un-indented, we show it cleanly without
      showing a full line change. These are shown by >>>> and <<<<
      markers on lines, which you can see in /r/2/diff/ and in
      /r/2/diff/1-2/

      Unlike most diff viewers, you won't have to waste your time examining
      every line that was indented, looking for changes.

      This will even differentiate between spaces and tabs. If someone
      accidentally indents the wrong way, you'll know.

    • See changes made within a line

      When replacing just part of a line, we highlight the changes, making
      it much easier to see the addition of a word, renaming of a variable,
      or even the accidental removal of a semicolon.

    • Interdiffs

      When reviewing multiple iterations of a change, you can view an
      "interdiff," the diff between two diffs. It's easy to see what has
      actually changed. For example, see /r/2/diff/1-2/

    • Multi-commit diffs

      Whether one commit or a hundred, you can post it to Review Board.

      Reviewers can look at the entirety of your work as one change,
      dig into individual commits, or view any range of commits they want.

    • Download any file in the diff

      Simply click the little down arrow next to the "Revision" or "New
      Change" in the diff's header to download the full content of either
      the file on the left-hand side or right-hand side.

    Click View Diff in the top-right to look at the diff for this review
    request to play around with the diffs.

    
     
    Description From Last Updated

    do we realy need this change?

    guest2956guest2956

    another comment fsdfs fsdfsd fsdfs fsdfsdfs

    guest1777guest1777

    Feedback from Aleksei !! This is important

    guest1777guest1777

    test comment

    guest8655guest8655

    This is another comment from Aleksei !!!!

    guest1777guest1777

    Comments can be made across multiple lines. You might even want to suggest code, like: if value is not None: …

    chipx86chipx86

    We can then have a discussion on it. Maybe I think this code is better: if not (not value): ... …

    chipx86chipx86

    test require verif

    guest6065guest6065

    self on a shelf

    guest9969guest9969

    test

    guest4245guest4245
    chipx86
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
       
       
       
       
       
       
      Show all issues

      Comments can be made across multiple lines.

      You might even want to suggest code, like:

      if value is not None:
          # The rest of the code would go here...
          value_html = ...
      

      Note also how this comment opens an issue. We can use this to track what work still needs to be done on the diff.

      1. We can then have a discussion on it. Maybe I think this code is better:

        if not (not value):
            ...
        

        (It's not.)

    3. 
        
    guest9770
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revisions 1 - 2)
       
       
       
       
       

      dddd

    3. 
        
    guest9770
    1. sdsd

    2. 
        
    guest8655
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      test comment

    3. 
        
    guest2956
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
       
       
      Show all issues

      do we realy need this change?

    3. 
        
    guest6065
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      test require verif

    3. 
        
    guest1777
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      another comment

      • fsdfs
      • fsdfsd
      • fsdfs

      fsdfsdfs

    3. 
        
    guest1777
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      Feedback from Aleksei !!

      This is important

    3. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      This is another comment from Aleksei !!!!

    4. 
        
    guest196
    1. title

    2. 
        
    guest196
    1. Ship It!
    2. 
        
    guest4245
    1. Ship It!

    2. 
        
    guest4245
    1. 1

    2. 
        
    guest4245
    1. 
        
    2. 1
    3. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      test

    4. 
        
    guest9051
    1. Ship It!
      1. first time try to use review board

    2. 
        
    guest9969
    1. 
        
    2. reviewboard/reviews/fields.py (Diff revision 2)
       
       
      Show all issues

      self on a shelf

    3.