Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+25 -29) |
Diff viewer demo
Review Request #2 — Created Sept. 12, 2016 and updated
Information | |
---|---|
chipx86 | |
Review Board | |
master | |
5, 470, 1264, 613 | |
Reviewers | |
demo | |
The Review Board diff viewer is one of the best on the market. It has many ways to help
you look through a change and focus on what's important.Here's just a few of the features we provide:
-
Detailed file index
The file index lists all the files modified in the diff, along with a graph showing the
relative number of inserts, deletes, and replaces.The thickness of the ring shows how much of the file is modified (and will be a full red
or green circle, if the file is deleted or added).The colored dots on the side link to the matching changed chunks for that file.
-
Multi-line commenting
Click a line number, or click and drag down several lines to comment on those lines.
-
Syntax highlighting
Every diff is syntax-highlighted, making it easier to see, for instance, what's a string
and what's a reserved keyword.This supports highlighting file formats of all kinds.
-
Collapsable diffs
Diffs are shown collapsed, only showing what changed and the immediate lines around it.
A header is shown above each change, showing the nearest function or class. Clicking on the
header will show all unchangedl ines up to that function or class.Alternatively, click the
[+] 20
to show 20 more lines, or the[+]
to show all the lines
hidden behind that header.
-
Moved code detection
Significant code changes that move around a file are specially shown with little move flags
saying where they went to or where they came from. You can rely on these to know that you
don't need to give that code another look.For example, see how the
__init__
function was moved in /r/2/diff/
-
Interdiffs
When reviewing multiple iterations of a change, you can view an "interdiff," the diff
between two diffs. It's easy to see what has actually changed. For example, see /r/2/diff/1-2/
-
Indentation change indicators
When code is indented or un-indented, we show it cleanly without showing a full line change.
These are shown by>>>>
and<<<<
markers on lines, which you can see in /r/2/diff/ and in
/r/2/diff/1-2/Unlike most diff viewers, you won't have to waste your time examining every line that was
indented, looking for changes.This will even differentiate between spaces and tabs. If someone accidentally indents
the wrong way, you'll know.
-
See changes made within a line
When replacing just part of a line, we highlight the changes, making it much easier to see
the addition of a word, renaming of a variable, or even the accidental removal of a semicolon.
-
Download any file in the diff
Simply click the little down arrow next to the "Revision" or "New Change" in the diff's
header to download the full content of either the file on the left-hand side or right-hand
side.
Click View Diff in the top-right to look at the diff for this review request
to play around with the diffs.
Description | From | Last Updated |
---|---|---|
test |
|
|
typo |
|
|
What this means? |
|
|
Cooltoo |
|
|
error! |
|
|
This is a bug(test) |
|
|
testing fix it then ship it |
|
|
this is my comment |
|
|
test comment |
|
|
Test |
|
|
comment |
|
|
Your face is full of cheddar. |
|
|
1 |
|
|
???????????? |
|
|
amazing |
|
|
Test comment2 |
|
|
Test comment 3 |
|
|
asdf |
|
|
pole ok |
|
|
New issue: test |
|
|
ata |
|
|
general comments |
|
|
change this one @@@@@@@@@@@@@@@ |
|
|
why was this moved |
|
|
hi |
|
|
stuff |
|
|
This is my comment |
|
|
Test |
|
|
Why are we doing this? |
|
|
181-184???? |
|
|
list is right |
|
|
Missing class java doc. |
|
|
good |
|
|
lol |
|
|
multiline? |
|
|
this is something |
|
|
test |
|
|
this is test comment |
|
|
Entering a comment. |
|
|
aaa |
|
|
bla |
|
|
Hmm |
|
|
Why do you move this |
|
|
Delete this unneccesary crap. |
|
|
why delete it? |
|
|
U can do it |
|
|
test |
|
|
asdf |
|
|
finde ich doof |
|
|
this should not be moved. |
|
|
New Comment |
|
|
what is this? |
|
|
test |
|
|
sss |
|
|
This is a bug! |
|
|
test |
|
|
===== this is an issue ===== |
|
|
mmm |
|
|
sadfasdfs |
|
|
rrrrr |
|
|
hi |
|
|
foobar |
|
|
hello |
|
|
‘’ ‘’ |
|
|
Test require verification comment. |
|
|
Critical; test |
|
|
This looks great |
|
|
YO MOMMA |
|
|
ggg |
|
|
good?? |
|
|
Can selected rows.Great~ |
|
|
This is test!! |
|
|
;ll;l;l |
|
|
asdf |
|
|
Test issue |
|
|
Hey, I like this! |
|
|
This text is italic |
|
|
test2 |
|
|
remove this line |
|
|
Test |
|
|
Just Wrong! |
|
|
probme |
|
|
this is a bug plese fix it |
|
|
wait, what? |
|
|
oh dear |
|
|
This text is not necessary - please revise it to make it shorter. |
|
|
test |
|
|
just kidding you |
|
|
2323232 |
|
|
test |
|
|
1 |
|
|
test issue |
|
|
iiiii |
|
|
dssdd |
|
|
remove that code |
|
|
Bad |
|
|
no |
|
|
why change new_value to 'old' in info:? |
|
|
esto no me gusta |
|
|
nice! |
|
|
change the logic. |
|
|
333333 |
|
|
What is this, can you explain to me? |
|
|
Fix this. |
|
|
Comments can be made across multiple lines. You might even want to suggest code, like: if value is not None: ... |
|
|
This is weird. check again |
|
|
This comment requires verification |
|
|
Where the hell is the else branch??? Come imedeatly to my office |
|
|
asdfasdfasdfasdf |
|
|
Surely this shouldn't be here This text has a link to wikipedia |
|
|
Looking good. |
|
|
just for test |
|
|
Test multi-line comment! |
|
|
fdasfd |
|
|
my comment import os os.path.exist() |
|
|
ooooooooooooh |
|
|
cambiemos el nombre de la variable |
|
|
jhgkjhgk |
|
|
hi |
|
|
qqgqgqggq |
|
|
hi add ne user @guest23 |
|
|
not sure if this is a good idea. :) |
|
|
test 123 |
|
|
asfdasdfsaf |
|
|
Comments are unclear |
|
|
nothing wrong.just kidding you.haha |
|
|
You forgot to update this too. |
|
|
Is this method really still needed? |
|
|
test |
|
|
What's wrong with this though? |
|
|
Old |
|
|
change test |
|
|
This is obviously wrong. |
|
|
fatal bug(markdown) |
|
|
better not. |
|
|
wegweqgweg |
|
|
old value |
|
|
oh this is a pain in the tucus!! |
|
|
pickle riiiiiiiiiiiiick |
|
|
test |
|
-
-
reviewboard/reviews/fields.py (Diff revision 2) Comments can be made across multiple lines.
You might even want to suggest code, like:
if value is not None: # The rest of the code would go here... value_html = ...
Note also how this comment opens an issue. We can use this to track what work still needs to be done on the diff.
-
Ship It!
-
-
reviewboard/reviews/fields.py (Diff revision 2) Where the hell is the else branch??? Come imedeatly to my office
-
Somebody cannot write
-
-
reviewboard/reviews/fields.py (Diff revision 2) Surely this shouldn't be here
This text has a link to wikipedia
-
-
-
reviewboard/reviews/fields.py (Diff revision 2) Test code in lists:
- List item
-
Another list item
Code in list
-
More list items
-
Please fix it
-
-
reviewboard/reviews/fields.py (Diff revision 2) old_lines, new_lines - check values before pass to differ
-
-
reviewboard/reviews/fields.py (Diff revision 2) This text is not necessary - please revise it to make it shorter.